You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by ya...@apache.org on 2015/07/21 23:56:57 UTC

samza git commit: SAMZA-732: added max memory to the metrics gathered from the JVM

Repository: samza
Updated Branches:
  refs/heads/master e9f700861 -> b22909855


SAMZA-732: added max memory to the metrics gathered from the JVM


Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/b2290985
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/b2290985
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/b2290985

Branch: refs/heads/master
Commit: b22909855a1ae9e93e4b1d7282f89dd6b8c10eae
Parents: e9f7008
Author: Shadi A. Noghabi <ab...@illinois.edu>
Authored: Tue Jul 21 14:56:57 2015 -0700
Committer: Yan Fang <ya...@gmail.com>
Committed: Tue Jul 21 14:56:57 2015 -0700

----------------------------------------------------------------------
 .../src/main/scala/org/apache/samza/metrics/JvmMetrics.scala | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/samza/blob/b2290985/samza-core/src/main/scala/org/apache/samza/metrics/JvmMetrics.scala
----------------------------------------------------------------------
diff --git a/samza-core/src/main/scala/org/apache/samza/metrics/JvmMetrics.scala b/samza-core/src/main/scala/org/apache/samza/metrics/JvmMetrics.scala
index a95a0ec..64daa0f 100644
--- a/samza-core/src/main/scala/org/apache/samza/metrics/JvmMetrics.scala
+++ b/samza-core/src/main/scala/org/apache/samza/metrics/JvmMetrics.scala
@@ -50,8 +50,10 @@ class JvmMetrics(val registry: MetricsRegistry) extends MetricsHelper with Runna
   // jvm metrics
   val gMemNonHeapUsedM = newGauge("mem-non-heap-used-mb", 0.0F)
   val gMemNonHeapCommittedM = newGauge("mem-non-heap-committed-mb", 0.0F)
+  val gMemNonHeapMaxM = newGauge("mem-non-heap-max-mb", 0.0F)
   val gMemHeapUsedM = newGauge("mem-heap-used-mb", 0.0F)
   val gMemHeapCommittedM = newGauge("mem-heap-committed-mb", 0.0F)
+  val gMemHeapMaxM = newGauge("mem-heap-max-mb", 0.0F)
   val gThreadsNew = newGauge("threads-new", 0L)
   val gThreadsRunnable = newGauge("threads-runnable", 0L)
   val gThreadsBlocked = newGauge("threads-blocked", 0L)
@@ -72,8 +74,8 @@ class JvmMetrics(val registry: MetricsRegistry) extends MetricsHelper with Runna
     updateGcUsage
     updateThreadUsage
 
-    debug("updated metrics to: [%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s]" format
-      (gMemNonHeapUsedM, gMemNonHeapCommittedM, gMemHeapUsedM, gMemHeapCommittedM, gThreadsNew,
+    debug("updated metrics to: [%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s]" format
+      (gMemNonHeapUsedM, gMemNonHeapCommittedM, gMemNonHeapMaxM, gMemHeapUsedM, gMemHeapCommittedM,gMemHeapMaxM, gThreadsNew,
         gThreadsRunnable, gThreadsBlocked, gThreadsWaiting, gThreadsTimedWaiting,
         gThreadsTerminated, cGcCount, cGcTimeMillis))
   }
@@ -85,8 +87,10 @@ class JvmMetrics(val registry: MetricsRegistry) extends MetricsHelper with Runna
     val memHeap = memoryMXBean.getHeapMemoryUsage()
     gMemNonHeapUsedM.set(memNonHeap.getUsed() / M)
     gMemNonHeapCommittedM.set(memNonHeap.getCommitted() / M)
+    gMemNonHeapMaxM.set(memNonHeap.getMax / M)
     gMemHeapUsedM.set(memHeap.getUsed() / M)
     gMemHeapCommittedM.set(memHeap.getCommitted() / M)
+    gMemHeapMaxM.set(memHeap.getMax() / M)
   }
 
   private def updateGcUsage {