You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by xx...@apache.org on 2022/12/13 10:25:27 UTC

[kylin] 20/25: KYLIN-5274 Fix sonar

This is an automated email from the ASF dual-hosted git repository.

xxyu pushed a commit to branch kylin5
in repository https://gitbox.apache.org/repos/asf/kylin.git

commit ce432fa60cdacaffaaaa8fb23b6952e4051c9cab
Author: Junqing Cai <ca...@163.com>
AuthorDate: Mon Oct 17 10:11:33 2022 +0800

    KYLIN-5274 Fix sonar
---
 .../src/main/java/org/apache/kylin/common/KylinConfigBase.java        | 4 ++--
 .../main/java/org/apache/kylin/common/KylinExternalConfigLoader.java  | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java b/src/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
index 33f7f0b5f1..e64192aa3f 100644
--- a/src/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
+++ b/src/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
@@ -163,10 +163,10 @@ public abstract class KylinConfigBase implements Serializable {
     }
 
     public Map<String, String> getReadonlyProperties() {
-        val substitutor = getSubstitutor();
+        val subStitutorTmp = getSubstitutor();
         HashMap<String, String> config = Maps.newHashMap();
         for (Entry<Object, Object> entry : this.properties.entrySet()) {
-            config.put((String) entry.getKey(), substitutor.replace((String) entry.getValue()));
+            config.put((String) entry.getKey(), subStitutorTmp.replace((String) entry.getValue()));
         }
         return config;
     }
diff --git a/src/core-common/src/main/java/org/apache/kylin/common/KylinExternalConfigLoader.java b/src/core-common/src/main/java/org/apache/kylin/common/KylinExternalConfigLoader.java
index 206539dd7a..880e3ab52f 100644
--- a/src/core-common/src/main/java/org/apache/kylin/common/KylinExternalConfigLoader.java
+++ b/src/core-common/src/main/java/org/apache/kylin/common/KylinExternalConfigLoader.java
@@ -167,6 +167,7 @@ public class KylinExternalConfigLoader implements ICachedExternalConfigLoader {
 
     /**
      * @see #getPropertyEntries
+     * @deprecated
      */
     @Override
     @Deprecated