You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/18 15:04:41 UTC

[GitHub] [beam] RyanSkraba commented on a change in pull request #12299: [BEAM-10523] Add support for custom DatumWriters to AvroIO.Write

RyanSkraba commented on a change in pull request #12299:
URL: https://github.com/apache/beam/pull/12299#discussion_r472258515



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java
##########
@@ -1273,6 +1273,9 @@ public void populateDisplayData(DisplayData.Builder builder) {
     @Nullable
     abstract DynamicAvroDestinations<UserT, DestinationT, OutputT> getDynamicDestinations();
 
+    @Nullable

Review comment:
       Just note when you rebase -- the order of `@Nullable` and `abstract` has changed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org