[jira] [Commented] (ROCKETMQ-215) Use java 7 syntax to refator code base

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040570#comment-16040570 ] 

ASF GitHub Bot commented on ROCKETMQ-215:
-----------------------------------------

GitHub user dzyangxi opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/117

    remove

    JIRA:https://issues.apache.org/jira/browse/ROCKETMQ-215?jql=project%20%3D%20ROCKETMQ

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dzyangxi/incubator-rocketmq develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #117
    
----
commit 38764652b24992d839eab4c2cb50940a473e40f4
Author: yangxixi <xi...@56qq.com>
Date:   2017-06-07T08:52:11Z

    remove

----


> Use java 7 syntax to refator code base
> --------------------------------------
>
>                 Key: ROCKETMQ-215
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-215
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-broker, rocketmq-namesrv, rocketmq-store
>            Reporter: Jaskey Lam
>            Assignee: yukon
>            Priority: Minor
>
> code base may have some code like 
> {code}
>     private ConcurrentMap<String/* topic@group */, ConcurrentMap<Integer, Long>> offsetTable =
>         new ConcurrentHashMap<String, ConcurrentMap<Integer, Long>>(512);
> {code}
> Atucally, with java7, it can be simplied to 
> {code}
>     private ConcurrentMap<String/* topic@group */, ConcurrentMap<Integer, Long>> offsetTable =
>         new ConcurrentHashMap<>(512);
> {code}
> Which is cleaner. 
> Since rocketmq broker require jdk which is greater or higher than java7, this can be improved.
> But rocketmq client should still remains compatible with jdk 1.6



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)