You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/08/15 00:43:28 UTC

[jira] Created: (MPECLIPSE-38) Jar overrides are not supported

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-38

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-38
    Summary: Jar overrides are not supported
       Type: Bug

     Status: Unassigned
   Priority: Critical

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-eclipse-plugin
   Versions:
             1.5
             1.0
             1.1
             1.2
             1.3
             1.4
             1.6
             1.7
             1.8

   Assignee: 
   Reporter: Chuck Daniels

    Created: Sat, 14 Aug 2004 6:42 PM
    Updated: Sat, 14 Aug 2004 6:42 PM
Environment: all

Description:
This plugin is unusable for projects that contain jar overrides.  Jar override properties are completely ignored and overridden jars are assumed to exist in the local repository.  Obviously this is incorrect since such jars are overridden exactly because they do NOT reside in the local repository.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MPECLIPSE-38) Jar overrides are not supported

Posted by ji...@codehaus.org.
Message:

   The following issue has been closed.

   Resolver: David Eric Pugh
       Date: Fri, 24 Sep 2004 8:29 AM

I added a unit test to verify that jar overrides work..  Check it out, and reopen if you disagree..  A unit test demontrating what you mean would be good.
---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-38

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-38
    Summary: Jar overrides are not supported
       Type: Bug

     Status: Closed
   Priority: Critical
 Resolution: CANNOT REPRODUCE

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-eclipse-plugin
   Fix Fors:
             1.9
   Versions:
             1.5
             1.0
             1.1
             1.2
             1.3
             1.4
             1.6
             1.7
             1.8

   Assignee: David Eric Pugh
   Reporter: Chuck Daniels

    Created: Sat, 14 Aug 2004 6:42 PM
    Updated: Fri, 24 Sep 2004 8:29 AM
Environment: all

Description:
This plugin is unusable for projects that contain jar overrides.  Jar override properties are completely ignored and overridden jars are assumed to exist in the local repository.  Obviously this is incorrect since such jars are overridden exactly because they do NOT reside in the local repository.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MPECLIPSE-38) Jar overrides are not supported

Posted by ji...@codehaus.org.
Message:

   The following issue has been closed.

   Resolver: David Eric Pugh
       Date: Fri, 24 Sep 2004 11:58 AM

okay, now it all works properly!
---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-38

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-38
    Summary: Jar overrides are not supported
       Type: Bug

     Status: Closed
   Priority: Critical
 Resolution: FIXED

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-eclipse-plugin
   Fix Fors:
             1.9
   Versions:
             1.5
             1.0
             1.1
             1.2
             1.3
             1.4
             1.6
             1.7
             1.8

   Assignee: David Eric Pugh
   Reporter: Chuck Daniels

    Created: Sat, 14 Aug 2004 6:42 PM
    Updated: Fri, 24 Sep 2004 11:58 AM
Environment: all

Description:
This plugin is unusable for projects that contain jar overrides.  Jar override properties are completely ignored and overridden jars are assumed to exist in the local repository.  Obviously this is incorrect since such jars are overridden exactly because they do NOT reside in the local repository.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPECLIPSE-38) Jar overrides are not supported

Posted by ji...@codehaus.org.
The following comment has been added to this issue:

     Author: Sebastien Sahuc
    Created: Fri, 24 Sep 2004 2:05 PM
       Body:
Thanks for the fix. Unfortunately I'm tempted in reopening the bug (once I figure how to do it ;-) )

The fix is actually not working properly if the jar itself isn't located in the mavenrepo. 

Let's take an example that part of our build scheme:

In the build.properties we defines the following (variable defined in maven script loader): 

maven.jar.tools               = ${tools.jar}

Then in the project.xml we defined the dependency:

        <dependency>
            <id>tools</id>
        </dependency>


This unfortunately ends up being wrong in the final .classpath generated by the eclipse plugin. 

Here is the patch we're using for the moment until a final solution is found for those overriden jar that doesn't exist in the maven repository.

Index: classpath.jelly
===================================================================
RCS file: /home/cvspublic/maven-plugins/eclipse/src/plugin-resources/templates/classpath.jelly,v
retrieving revision 1.21
diff -u -r1.21 classpath.jelly
--- classpath.jelly	24 Sep 2004 15:51:01 -0000	1.21
+++ classpath.jelly	24 Sep 2004 17:58:02 -0000
@@ -145,6 +145,10 @@
       <j:when test="${lib.dependency.groupId == 'cactus' and ignoreCactus}">
         <!-- ignoring junit dependency as we've already created it -->
       </j:when>
+      <j:when test="${lib.dependency.id == 'tools:tools'}">
+          <!-- add tools.jar specified from maven tools.jar location -->
+          <classpathentry kind="lib" path="${lib.path}"/>
+      </j:when>
       <j:otherwise>
         <!-- make sure it's a classpath dependency -->
         <j:set var="isClasspath" value="${lib.dependency.isAddedToClasspath()}"/>


---------------------------------------------------------------------
View this comment:
  http://jira.codehaus.org/browse/MPECLIPSE-38?page=comments#action_24538

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-38

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-38
    Summary: Jar overrides are not supported
       Type: Bug

     Status: Closed
   Priority: Critical
 Resolution: FIXED

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-eclipse-plugin
   Fix Fors:
             1.9
   Versions:
             1.5
             1.0
             1.1
             1.2
             1.3
             1.4
             1.6
             1.7
             1.8

   Assignee: David Eric Pugh
   Reporter: Chuck Daniels

    Created: Sat, 14 Aug 2004 6:42 PM
    Updated: Fri, 24 Sep 2004 2:05 PM
Environment: all

Description:
This plugin is unusable for projects that contain jar overrides.  Jar override properties are completely ignored and overridden jars are assumed to exist in the local repository.  Obviously this is incorrect since such jars are overridden exactly because they do NOT reside in the local repository.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPECLIPSE-38) Jar overrides are not supported

Posted by ji...@codehaus.org.
The following comment has been added to this issue:

     Author: David Eric Pugh
    Created: Fri, 24 Sep 2004 4:28 PM
       Body:
Go ahead and reopoen it..  I think the challenge I ran into was the need to have it be relative to an Eclipse classpath variable...   I'd be happy to see any patches you can offer.
---------------------------------------------------------------------
View this comment:
  http://jira.codehaus.org/browse/MPECLIPSE-38?page=comments#action_24550

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-38

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-38
    Summary: Jar overrides are not supported
       Type: Bug

     Status: Closed
   Priority: Critical
 Resolution: FIXED

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-eclipse-plugin
   Fix Fors:
             1.9
   Versions:
             1.5
             1.0
             1.1
             1.2
             1.3
             1.4
             1.6
             1.7
             1.8

   Assignee: David Eric Pugh
   Reporter: Chuck Daniels

    Created: Sat, 14 Aug 2004 6:42 PM
    Updated: Fri, 24 Sep 2004 4:28 PM
Environment: all

Description:
This plugin is unusable for projects that contain jar overrides.  Jar override properties are completely ignored and overridden jars are assumed to exist in the local repository.  Obviously this is incorrect since such jars are overridden exactly because they do NOT reside in the local repository.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Reopened: (MPECLIPSE-38) Jar overrides are not supported

Posted by ji...@codehaus.org.
Message:

   The following issue has been reopened.

   Reopener: David Eric Pugh
       Date: Fri, 24 Sep 2004 11:54 AM

Turns out what I understood as jar overrides was wrong.
---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-38

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-38
    Summary: Jar overrides are not supported
       Type: Bug

     Status: Reopened
   Priority: Critical

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-eclipse-plugin
   Fix Fors:
             1.9
   Versions:
             1.5
             1.0
             1.1
             1.2
             1.3
             1.4
             1.6
             1.7
             1.8

   Assignee: David Eric Pugh
   Reporter: Chuck Daniels

    Created: Sat, 14 Aug 2004 6:42 PM
    Updated: Fri, 24 Sep 2004 11:54 AM
Environment: all

Description:
This plugin is unusable for projects that contain jar overrides.  Jar override properties are completely ignored and overridden jars are assumed to exist in the local repository.  Obviously this is incorrect since such jars are overridden exactly because they do NOT reside in the local repository.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org