You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ScrapCodes <gi...@git.apache.org> on 2014/08/21 11:22:22 UTC
[GitHub] spark pull request: [SPARK-2988] - Port repl to scala 2.11.
GitHub user ScrapCodes opened a pull request:
https://github.com/apache/spark/pull/2079
[SPARK-2988] - Port repl to scala 2.11.
Why do we need to port the repl for scala 2.11, especially when scala repl has class based wrappers ?
We need to do this, because they are not sufficient for our needs. Also scala repl does not allow us to plugin our own wrappers and access mechanism. Because most of the things in repl are private and can not be inherited. So only choice left was to copy the code in to our code base and make adjustments. The reason class based wrappers are not sufficient is in short "directly importing the created objects by import wrappers results in recreation on remote nodes". So we import by first referring to them as `INSTANCE` in the object. Please take a look at the patch for more details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ScrapCodes/spark-1 repl-port
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2079.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2079
----
commit b1a40215b6de41f2da0915c528e4f82f81657f53
Author: Prashant Sharma <pr...@imaginea.com>
Date: 2014-08-12T10:55:57Z
Adjust build system and tests to work with scala 2.11
commit 645a5b764d9dd084474af5b9dae3289176f5e80e
Author: Prashant Sharma <pr...@imaginea.com>
Date: 2014-08-20T12:48:15Z
Few more fixes/ improvements to jenkins build.
commit d12ae04d9b626c46ebe53e02cf796fd65b9cb42c
Author: Prashant Sharma <pr...@imaginea.com>
Date: 2014-08-21T07:22:19Z
Added ported scala repl for scala 2.11
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2988] - Port repl to scala 2.11.
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2079#issuecomment-52901077
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19048/consoleFull) for PR 2079 at commit [`514e75a`](https://github.com/apache/spark/commit/514e75a993dddd89e14a5d6b5e892d6e8da34447).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2988] - Port repl to scala 2.11.
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2079#issuecomment-54695582
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19866/consoleFull) for PR 2079 at commit [`514e75a`](https://github.com/apache/spark/commit/514e75a993dddd89e14a5d6b5e892d6e8da34447).
* This patch **fails** unit tests.
* This patch **does not** merge cleanly!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2988] - Port repl to scala 2.11.
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2079#issuecomment-52907540
**Tests timed out** after a configured wait of `120m`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2988] - Port repl to scala 2.11.
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2079#issuecomment-52910803
**Tests timed out** after a configured wait of `120m`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2988] - Port repl to scala 2.11.
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes closed the pull request at:
https://github.com/apache/spark/pull/2079
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2988] - Port repl to scala 2.11.
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2079#issuecomment-54694989
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19866/consoleFull) for PR 2079 at commit [`514e75a`](https://github.com/apache/spark/commit/514e75a993dddd89e14a5d6b5e892d6e8da34447).
* This patch **does not** merge cleanly!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2988] - Port repl to scala 2.11.
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2079#issuecomment-52897341
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19046/consoleFull) for PR 2079 at commit [`d12ae04`](https://github.com/apache/spark/commit/d12ae04d9b626c46ebe53e02cf796fd65b9cb42c).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2988] - Port repl to scala 2.11.
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/2079#issuecomment-52900079
This patch is continuation of #1905 and should be merged after that. The diffs will be simplified once the other PR is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org