You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/06/07 00:20:05 UTC

[GitHub] [incubator-pinot] s-sahay commented on issue #4285: Fix the potential overflow for numGroupsLimit in CombineGroupByOperator

s-sahay commented on issue #4285: Fix the potential overflow for numGroupsLimit in CombineGroupByOperator
URL: https://github.com/apache/incubator-pinot/pull/4285#issuecomment-499715505
 
 
   @Jackie-Jiang : Can we add a test that would catch this kind of issue? Doing it for all config values may be a stretch but can we add one for this which can test the code path with config values set to min/max?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org