You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/20 16:00:59 UTC

[GitHub] [pulsar] wangzhiwubigdata opened a new pull request #14388: [pulsar-client-tools] Change IllegalArgumentException to ParameterException in CLI

wangzhiwubigdata opened a new pull request #14388:
URL: https://github.com/apache/pulsar/pull/14388


   ### Motivation
   
   Change IllegalArgumentException to ParameterException in CLI
   
   ### Modifications
   
   pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBookies.java
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API: (yes / **no**)
     - The schema: (yes / **no** / don't know)
     - The default values of configurations: (yes / **no**)
     - The wire protocol: (yes / **no**)
     - The rest endpoints: (yes / **no**)
     - The admin cli options: (yes / **no**)
     - Anything that affects deployment: (yes / **no** / don't know)
   
   ### Documentation
   
   - [x] `no-need-doc` 
     


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #14388: [pulsar-client-tools] Change IllegalArgumentException to ParameterException in CLI

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14388:
URL: https://github.com/apache/pulsar/pull/14388


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wangzhiwubigdata commented on pull request #14388: [pulsar-client-tools] Change IllegalArgumentException to ParameterException in CLI

Posted by GitBox <gi...@apache.org>.
wangzhiwubigdata commented on pull request #14388:
URL: https://github.com/apache/pulsar/pull/14388#issuecomment-1046273601


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #14388: [pulsar-client-tools] Change IllegalArgumentException to ParameterException in CLI

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14388:
URL: https://github.com/apache/pulsar/pull/14388#issuecomment-1048448524


   Just link more context here about the [github_stale](https://github.com/actions/stale)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wangzhiwubigdata commented on pull request #14388: [pulsar-client-tools] Change IllegalArgumentException to ParameterException in CLI

Posted by GitBox <gi...@apache.org>.
wangzhiwubigdata commented on pull request #14388:
URL: https://github.com/apache/pulsar/pull/14388#issuecomment-1049944086


   
   @codelipenghui @yuruguo  i have added a test  in CLITest.java😄


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org