You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by di...@incubator.apache.org on 2004/08/26 08:03:19 UTC

[jira] Created: (DIRSNICKERS-93) without equals implementation in Add/Delete stubs tests are invalid

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/DIRSNICKERS-93

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: DIRSNICKERS-93
    Summary: without equals implementation in Add/Delete stubs tests are invalid
       Type: Bug

     Status: Open
   Priority: Major

    Project: Directory Snickers
 Components: 
             LDAP Provider

   Assignee: Alex Karasulu
   Reporter: Alex Karasulu

    Created: Wed, 25 Aug 2004 11:02 PM
    Updated: Wed, 25 Aug 2004 11:02 PM

Description:
I just realized that the tests for add and delete req/resp pairs are using the parent equals() methods from the AbstractMessage base class which only compares the type, controls and message ids of Messages.  We need to make sure the req/resp pairs factor in additional attributes while determining equality.

For the responses we can kill two birds with one stone by overriding AbstractMessage.equals() within the AbstractResultResponse.  This way we can compare the result properties in one place to determine equality.

The Add and Delete requests are going to need their own equals() overrides within AddRequestImpl and DeleteRequestImpl. 


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[jira] Closed: (DIRSNICKERS-93) without equals implementation in Add/Delete stubs tests are invalid

Posted by di...@incubator.apache.org.
Message:

   The following issue has been closed.

   Resolver: Alex Karasulu
       Date: Thu, 26 Aug 2004 12:32 AM

Committed test cases and equals additions for both Add and Delete requests on revision 37062.

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/DIRSNICKERS-93

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: DIRSNICKERS-93
    Summary: without equals implementation in Add/Delete stubs tests are invalid
       Type: Bug

     Status: Closed
   Priority: Major
 Resolution: FIXED

    Project: Directory Snickers
 Components: 
             LDAP Provider

   Assignee: Alex Karasulu
   Reporter: Alex Karasulu

    Created: Wed, 25 Aug 2004 11:02 PM
    Updated: Thu, 26 Aug 2004 12:32 AM

Description:
I just realized that the tests for add and delete req/resp pairs are using the parent equals() methods from the AbstractMessage base class which only compares the type, controls and message ids of Messages.  We need to make sure the req/resp pairs factor in additional attributes while determining equality.

For the responses we can kill two birds with one stone by overriding AbstractMessage.equals() within the AbstractResultResponse.  This way we can compare the result properties in one place to determine equality.

The Add and Delete requests are going to need their own equals() overrides within AddRequestImpl and DeleteRequestImpl. 


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira