You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ma...@apache.org on 2014/10/26 22:29:23 UTC

git commit: [SPARK-3925][SQL] Do not consider the ordering of qualifiers during comparison

Repository: spark
Updated Branches:
  refs/heads/master 677852c3f -> 0af7e514c


[SPARK-3925][SQL] Do not consider the ordering of qualifiers during comparison

The orderings should not be considered during the comparison between old qualifiers and new qualifiers.

Author: Liang-Chi Hsieh <vi...@gmail.com>

Closes #2783 from viirya/full_qualifier_comp and squashes the following commits:

89f652c [Liang-Chi Hsieh] modification for comment.
abb5762 [Liang-Chi Hsieh] More comprehensive comparison of qualifiers.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/0af7e514
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/0af7e514
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/0af7e514

Branch: refs/heads/master
Commit: 0af7e514c6790cb78ee216986c45dbfe1217cd7d
Parents: 677852c
Author: Liang-Chi Hsieh <vi...@gmail.com>
Authored: Sun Oct 26 14:29:13 2014 -0700
Committer: Michael Armbrust <mi...@databricks.com>
Committed: Sun Oct 26 14:29:13 2014 -0700

----------------------------------------------------------------------
 .../apache/spark/sql/catalyst/expressions/namedExpressions.scala   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/0af7e514/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
index d023db4..fe13a66 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
@@ -156,7 +156,7 @@ case class AttributeReference(name: String, dataType: DataType, nullable: Boolea
    * Returns a copy of this [[AttributeReference]] with new qualifiers.
    */
   override def withQualifiers(newQualifiers: Seq[String]) = {
-    if (newQualifiers == qualifiers) {
+    if (newQualifiers.toSet == qualifiers.toSet) {
       this
     } else {
       AttributeReference(name, dataType, nullable)(exprId, newQualifiers)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org