You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/08 13:21:46 UTC

[GitHub] [arrow] xhochy commented on a change in pull request #9045: ARROW-11180: [CI] cmake-format pre-commit hook doesn't run

xhochy commented on a change in pull request #9045:
URL: https://github.com/apache/arrow/pull/9045#discussion_r553939866



##########
File path: .pre-commit-config.yaml
##########
@@ -40,9 +40,10 @@ repos:
       - id: cmake-format
         name: CMake Format
         language: python
-        entry: bash -c "pip install cmake-format && python run-cmake-format.py --check"
-        entry: echo
-        files: ^(.*/CMakeLists.txt|.*.cmake)$
+        entry: cmake-format --in-place --autosort=false

Review comment:
       @xhochy Do you still want to avoid reformatting imported CMake files? 
   
   Yes, this helps with diffing against their upstream. We did do changes to them for our use case and this makes updating them simpler.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org