You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/31 14:53:14 UTC
[GitHub] [airflow] darwinyip opened a new pull request #15114: Pin pandas-gbq to <0.15.0
darwinyip opened a new pull request #15114:
URL: https://github.com/apache/airflow/pull/15114
closes: #15113
Pretty straightforward. Pins `pandas-gbq<0.15.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #15114: Pin pandas-gbq to <0.15.0
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #15114:
URL: https://github.com/apache/airflow/pull/15114#issuecomment-811170442
Reading the source, `_check_google_client_version` was actually a part of `_test_google_api_imports`, so Airflow really doesn’t need to call it separately. I think the call can simply be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15114: Pin pandas-gbq to <0.15.0
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15114:
URL: https://github.com/apache/airflow/pull/15114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #15114: Pin pandas-gbq to <0.15.0
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #15114:
URL: https://github.com/apache/airflow/pull/15114#issuecomment-811169141
Since the upstream actually removed this outright and no longer performs this check, IMO a better fix would be to remove this test from Airflow as well (maybe only when the function fails to import).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15114: Pin pandas-gbq to <0.15.0
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15114:
URL: https://github.com/apache/airflow/pull/15114#issuecomment-813497828
One comment for the future @darwinyip @kaxil :).
Not a big issue, but worth keeping in mind to always describe in the commit and comment in `setup.py` why we are adding such limits.
Why?
It makes it much easier to understand when to lift the limits and when to leave them in case of further changes. I am going to provide proper fix for few other packages dropping Python 3.6 binary pypi wheels in their recent release (PR is coming) but having a comment in setup.py for the pandas-gbq could be helpful for me to understand what was going on rather than guess it (It was by accident I found my changes coincided with this one).
It could have saved me a few builds to find out that I should not remove this one. I thought it was added because of transitive pandas -> numpy dependencies (which dropped support for 3.6 pypi binary releases and it's easiest in our case to limit them for <3.7 rather than build them in our image (this ain't easy). It would be a bit easier if we had it in `setup.py` as comment. or the commit message (and best if it is in both). It was a bit of luck that I looked at the PR comments to find out why this was added.
I will add comment in my upcoming PR explaining why we have that `<0.15.0` thingie.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15114: Pin pandas-gbq to <0.15.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15114:
URL: https://github.com/apache/airflow/pull/15114#issuecomment-811266066
[The Workflow run](https://github.com/apache/airflow/actions/runs/705783193) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #15114: Pin pandas-gbq to <0.15.0
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15114:
URL: https://github.com/apache/airflow/pull/15114#issuecomment-811202346
Agree with @uranusjr here, looks like it was just there to do some additional validation :)
cc @mik-laj @turbaszek who might know more, but feel free to remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org