You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "jpappa200 (via GitHub)" <gi...@apache.org> on 2023/02/08 19:55:36 UTC
[GitHub] [trafficcontrol] jpappa200 opened a new pull request, #7346: t3c remove stale git lock file
jpappa200 opened a new pull request, #7346:
URL: https://github.com/apache/trafficcontrol/pull/7346
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
When using git to track changes in etc/trafficserver sometimes the lock file isn't cleared and git will stop updating. This PR will cause t3c-apply to look for a lock file that is more than 5 min old and remove if it exists.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Control Cache Config (`t3c`, formerly ORT)
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
The best way to verify and to create an `index.lock` file in `/opt/trafficserver/etc/trafficserver/.git/` and tail `reval.log` and `syncds.log` when the file is 5 minutes old it will be cleared.
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
## PR submission checklist
- [ ] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #7346: t3c remove stale git lock file
Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 merged PR #7346:
URL: https://github.com/apache/trafficcontrol/pull/7346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7346: t3c remove stale git lock file
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7346:
URL: https://github.com/apache/trafficcontrol/pull/7346#issuecomment-1423166781
# [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7346?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7346](https://codecov.io/gh/apache/trafficcontrol/pull/7346?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de08b0f) into [master](https://codecov.io/gh/apache/trafficcontrol/commit/3aca8379aece0508f849b710d84856ad9ffa0d6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3aca837) will **increase** coverage by `5.77%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head de08b0f differs from pull request most recent head 316e841. Consider uploading reports for the commit 316e841 to get more accurate results
```diff
@@ Coverage Diff @@
## master #7346 +/- ##
============================================
+ Coverage 25.07% 30.84% +5.77%
Complexity 98 98
============================================
Files 593 405 -188
Lines 73616 35442 -38174
Branches 90 90
============================================
- Hits 18459 10932 -7527
+ Misses 53406 23434 -29972
+ Partials 1751 1076 -675
```
| Flag | Coverage Δ | |
|---|---|---|
| golib_unit | `53.15% <ø> (ø)` | |
| grove_unit | `4.60% <ø> (ø)` | |
| t3c_unit | `5.33% <0.00%> (-0.03%)` | :arrow_down: |
| traffic_monitor_unit | `20.43% <ø> (ø)` | |
| traffic_ops_unit | `?` | |
| traffic_stats_unit | `10.41% <ø> (ø)` | |
| unit_tests | `26.11% <0.00%> (+3.51%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/trafficcontrol/pull/7346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cache-config/t3c-apply/t3c-apply.go](https://codecov.io/gh/apache/trafficcontrol/pull/7346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2FjaGUtY29uZmlnL3QzYy1hcHBseS90M2MtYXBwbHkuZ28=) | `0.00% <0.00%> (ø)` | |
| [cache-config/t3c-apply/util/gitutil.go](https://codecov.io/gh/apache/trafficcontrol/pull/7346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2FjaGUtY29uZmlnL3QzYy1hcHBseS91dGlsL2dpdHV0aWwuZ28=) | `0.00% <0.00%> (ø)` | |
| [lib/go-atscfg/parentabstraction.go](https://codecov.io/gh/apache/trafficcontrol/pull/7346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2dvLWF0c2NmZy9wYXJlbnRhYnN0cmFjdGlvbi5nbw==) | `79.47% <0.00%> (-0.53%)` | :arrow_down: |
| [traffic\_ops/traffic\_ops\_golang/cdn/dnssec.go](https://codecov.io/gh/apache/trafficcontrol/pull/7346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2Nkbi9kbnNzZWMuZ28=) | | |
| [...ic\_ops\_golang/swaggerdocs/v13/profileparameters.go](https://codecov.io/gh/apache/trafficcontrol/pull/7346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3N3YWdnZXJkb2NzL3YxMy9wcm9maWxlcGFyYW1ldGVycy5nbw==) | | |
| [...ang/trafficvault/backends/postgres/url\_sig\_keys.go](https://codecov.io/gh/apache/trafficcontrol/pull/7346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3RyYWZmaWN2YXVsdC9iYWNrZW5kcy9wb3N0Z3Jlcy91cmxfc2lnX2tleXMuZ28=) | | |
| [...raffic\_ops\_golang/swaggerdocs/v13/physlocations.go](https://codecov.io/gh/apache/trafficcontrol/pull/7346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3N3YWdnZXJkb2NzL3YxMy9waHlzbG9jYXRpb25zLmdv) | | |
| [traffic\_ops/traffic\_ops\_golang/plugins/plugins.go](https://codecov.io/gh/apache/trafficcontrol/pull/7346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3BsdWdpbnMvcGx1Z2lucy5nbw==) | | |
| [...ffic\_ops/traffic\_ops\_golang/server/queue\_update.go](https://codecov.io/gh/apache/trafficcontrol/pull/7346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3NlcnZlci9xdWV1ZV91cGRhdGUuZ28=) | | |
| ... and [183 more](https://codecov.io/gh/apache/trafficcontrol/pull/7346?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] traeak commented on a diff in pull request #7346: t3c remove stale git lock file
Posted by "traeak (via GitHub)" <gi...@apache.org>.
traeak commented on code in PR #7346:
URL: https://github.com/apache/trafficcontrol/pull/7346#discussion_r1102774864
##########
cache-config/t3c-apply/t3c-apply.go:
##########
@@ -146,6 +146,19 @@ func Main() int {
}
if cfg.UseGit == config.UseGitYes || cfg.UseGit == config.UseGitAuto {
+ //need to see if there is an old lock file laying around.
+ const gitMaxLockAge = 5
Review Comment:
can you comment on the time units or put them in the variable name? Might be a pet peeve of mine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jpappa200 commented on a diff in pull request #7346: t3c remove stale git lock file
Posted by "jpappa200 (via GitHub)" <gi...@apache.org>.
jpappa200 commented on code in PR #7346:
URL: https://github.com/apache/trafficcontrol/pull/7346#discussion_r1102816910
##########
cache-config/t3c-apply/t3c-apply.go:
##########
@@ -146,6 +146,19 @@ func Main() int {
}
if cfg.UseGit == config.UseGitYes || cfg.UseGit == config.UseGitAuto {
+ //need to see if there is an old lock file laying around.
+ const gitMaxLockAge = 5
Review Comment:
Added comment and time units to variable name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] traeak commented on a diff in pull request #7346: t3c remove stale git lock file
Posted by "traeak (via GitHub)" <gi...@apache.org>.
traeak commented on code in PR #7346:
URL: https://github.com/apache/trafficcontrol/pull/7346#discussion_r1102774864
##########
cache-config/t3c-apply/t3c-apply.go:
##########
@@ -146,6 +146,19 @@ func Main() int {
}
if cfg.UseGit == config.UseGitYes || cfg.UseGit == config.UseGitAuto {
+ //need to see if there is an old lock file laying around.
+ const gitMaxLockAge = 5
Review Comment:
can you comment on the time units or put them in the variable name? Or make it so that its explicitly clear ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org