[jira] [Resolved] (SPARK-10691) Make Logistic, Linear Regression Model evaluate() method public

["Joseph K. Bradley (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-10691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joseph K. Bradley resolved SPARK-10691.
---------------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

Issue resolved by pull request 11928
[https://github.com/apache/spark/pull/11928]

> Make Logistic, Linear Regression Model evaluate() method public
> ---------------------------------------------------------------
>
>                 Key: SPARK-10691
>                 URL: https://issues.apache.org/jira/browse/SPARK-10691
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>            Reporter: Hao Ren
>            Assignee: Joseph K. Bradley
>             Fix For: 2.0.0
>
>
> The following method in {{LogisticRegressionModel}} is marked as {{private}}, which prevents users from creating a summary on any given data set. Check [here|https://github.com/feynmanliang/spark/blob/d219fa4c216e8f35b71a26921561104d15cd6055/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala#L272].
> {code}
> // TODO: decide on a good name before exposing to public API
> private[classification] def evaluate(dataset: DataFrame)
> : LogisticRegressionSummary = {
>     new BinaryLogisticRegressionSummary(
>         this.transform(dataset), 
>         $(probabilityCol), 
>         $(labelCol))
> }
> {code}
> This method is definitely necessary to test model performance.
> By the way, the name {{evaluate}} is already pretty good for me.
> [~mengxr] Could you check this ? Thx



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org