You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by chiwanpark <gi...@git.apache.org> on 2015/09/07 18:13:35 UTC
[GitHub] flink pull request: [FLINK-2619] [tests] Fix for some unexecuted S...
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/1103
[FLINK-2619] [tests] Fix for some unexecuted Scala tests
This PR includes to resolve FLINK-2619. The changes are following:
* Add JUnitRunner(`@RunWith(classOf[JUnitRunner])`) for unexecuted tests
* Reformat code style of some tests
With this changes, some tests fail. I tried to fix the tests. But I failed to fix them. Please advice me. If this issue is urgent, we can merge this and fix in other PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chiwanpark/flink FLINK-2619
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1103.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1103
----
commit ceb3ba6904492fb3fdefc4a0d6a6fd1e2c5d2b14
Author: Chiwan Park <ch...@apache.org>
Date: 2015-09-07T14:03:56Z
[FLINK-2619] [tests] Fix for some unexecuted Scala tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2619] [tests] Fix for some unexecuted S...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1103#issuecomment-138922680
Testing my patch, then merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2619] [tests] Fix for some unexecuted S...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1103#issuecomment-138489873
Looks, good, but one of the tests seems to be actually in error. I think that the instance created in the test simply does not have enough slots, so the test execution fails with "Not enough resources".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2619] [tests] Fix for some unexecuted S...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1103#issuecomment-138868121
Okay, the issue is that this mock execution never reaches a "FAILED" state in time, because the canceling of the other vertices (after one failed) is never acknowledged (by the mock TaskManager). I added the acknowledgements and now it works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2619] [tests] Fix for some unexecuted S...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1103#issuecomment-138497195
@StephanEwen Do you mean `ExecutionGraphRestartTest`? When I increased slots in test instance, I got another exception. Exception log is following:
```
org.scalatest.exceptions.TestFailedException: FAILING did not equal FAILED
at org.scalatest.MatchersHelper$.newTestFailedException(MatchersHelper.scala:160)
at org.scalatest.Matchers$ShouldMethodHelper$.shouldMatcher(Matchers.scala:6231)
at org.scalatest.Matchers$AnyShouldWrapper.should(Matchers.scala:6277)
at org.apache.flink.runtime.executiongraph.ExecutionGraphRestartTest$$anonfun$1$$anonfun$apply$mcV$sp$1.apply$mcV$sp(ExecutionGraphRestartTest.scala:68)
at org.apache.flink.runtime.executiongraph.ExecutionGraphRestartTest$$anonfun$1$$anonfun$apply$mcV$sp$1.apply(ExecutionGraphRestartTest.scala:40)
at org.apache.flink.runtime.executiongraph.ExecutionGraphRestartTest$$anonfun$1$$anonfun$apply$mcV$sp$1.apply(ExecutionGraphRestartTest.scala:40)
at org.scalatest.Transformer$$anonfun$apply$1.apply$mcV$sp(Transformer.scala:22)
at org.scalatest.OutcomeOf$class.outcomeOf(OutcomeOf.scala:85)
at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
at org.scalatest.Transformer.apply(Transformer.scala:22)
at org.scalatest.Transformer.apply(Transformer.scala:20)
at org.scalatest.WordSpecLike$$anon$1.apply(WordSpecLike.scala:953)
at org.scalatest.Suite$class.withFixture(Suite.scala:1122)
```
It seems because of checking job status before cleaning. But I cannot how to fix this.
Also I got an exception in `JobManagerRegistrationTest`. It seems that executed JobManager cannot receive message from test actor. After telling message to JM, JM is terminated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2619] [tests] Fix for some unexecuted S...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1103#issuecomment-138862613
Okay, let me merge your code and try to fix this test on the way...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2619] [tests] Fix for some unexecuted S...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1103
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2619] [tests] Fix for some unexecuted S...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1103#discussion_r38904456
--- Diff: flink-tests/src/test/scala/org/apache/flink/api/scala/misc/MassiveCaseClassSortingITCase.scala ---
@@ -35,11 +35,13 @@ import org.apache.flink.runtime.operators.sort.UnilateralSortMerger
import org.apache.flink.api.java.typeutils.runtime.RuntimeSerializerFactory
import org.junit.Assert._
import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable
+import org.junit.Test
class MassiveCaseClassSortingITCase {
val SEED : Long = 347569784659278346L
-
+
+ @Test
--- End diff --
Can you remove this one again? We wrote this as a manual test, because it takes forever to run. Would be great to have a Comment, though, and move it to the package `manual`, like the manual Java tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2619] [tests] Fix for some unexecuted S...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1103#issuecomment-138868908
Thanks for clarifying. I added a commit for the manual test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---