[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34672: [SPARK-37394][CORE] Skip registering with external shuffle server if a customized shuffle manager is configured

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #34672:
URL: https://github.com/apache/spark/pull/34672#discussion_r823037190



##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -529,7 +529,8 @@ private[spark] class BlockManager(
     }
 
     // Register Executors' configuration with the local shuffle service, if one should exist.
-    if (externalShuffleServiceEnabled && !blockManagerId.isDriver) {
+    if (externalShuffleServiceEnabled && !blockManagerId.isDriver
+      && shuffleManager.supportExternalShuffleService) {

Review comment:
       indentation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org