You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by je...@apache.org on 2020/05/04 16:23:06 UTC
[hadoop] branch branch-3.1 updated: YARN-10256. Refactor
TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic
(Ahmed Hussein via jeagles)
This is an automated email from the ASF dual-hosted git repository.
jeagles pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.1 by this push:
new e25ac17 YARN-10256. Refactor TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic (Ahmed Hussein via jeagles)
e25ac17 is described below
commit e25ac17e2b0a7bd860c17a0749c22a9cca2d6554
Author: Ahmed Hussein <ah...@apache.org>
AuthorDate: Mon May 4 10:13:51 2020 -0500
YARN-10256. Refactor TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic (Ahmed Hussein via jeagles)
Signed-off-by: Jonathan Eagles <je...@gmail.com>
(cherry picked from commit f5081a9a5d51fe781da97f07ac4dca8dd49c98e2)
---
.../scheduler/TestContainerSchedulerQueuing.java | 52 ++++++++--------------
1 file changed, 19 insertions(+), 33 deletions(-)
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/scheduler/TestContainerSchedulerQueuing.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/scheduler/TestContainerSchedulerQueuing.java
index a31eab5..c7b1118 100644
--- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/scheduler/TestContainerSchedulerQueuing.java
+++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/scheduler/TestContainerSchedulerQueuing.java
@@ -28,7 +28,6 @@ import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
-import com.google.common.base.Supplier;
import org.apache.hadoop.fs.UnsupportedFileSystemException;
import org.apache.hadoop.security.UserGroupInformation;
import org.apache.hadoop.test.GenericTestUtils;
@@ -1256,37 +1255,24 @@ public class TestContainerSchedulerQueuing extends BaseContainerManagerTest {
1, updateResponse.getSuccessfullyUpdatedContainers().size());
Assert.assertTrue(updateResponse.getFailedRequests().isEmpty());
- GetContainerStatusesRequest statRequest =
- GetContainerStatusesRequest.newInstance(Collections.singletonList(cId));
- GenericTestUtils.waitFor(
- new Supplier<Boolean>() {
- @Override
- public Boolean get() {
- try {
- List<ContainerStatus> containerStatuses = containerManager
- .getContainerStatuses(statRequest).getContainerStatuses();
- Assert.assertEquals(1, containerStatuses.size());
-
- ContainerStatus status = containerStatuses.get(0);
- Assert.assertEquals(
- org.apache.hadoop.yarn.api.records.ContainerState.RUNNING,
- status.getState());
-
- return status.getExecutionType() == ExecutionType.OPPORTUNISTIC;
- } catch (Exception ex) {
- throw new RuntimeException(ex);
- }
- }
- }, 100, 10000);
- List<ContainerStatus> containerStatuses = containerManager
- .getContainerStatuses(statRequest).getContainerStatuses();
- Assert.assertEquals(1, containerStatuses.size());
- for (ContainerStatus status : containerStatuses) {
- Assert.assertEquals(
- org.apache.hadoop.yarn.api.records.ContainerState.RUNNING,
- status.getState());
- Assert
- .assertEquals(ExecutionType.OPPORTUNISTIC, status.getExecutionType());
- }
+ final GetContainerStatusesRequest statRequest =
+ GetContainerStatusesRequest.newInstance(
+ Collections.singletonList(cId));
+ final org.apache.hadoop.yarn.api.records.ContainerState expectedState =
+ org.apache.hadoop.yarn.api.records.ContainerState.RUNNING;
+
+ GenericTestUtils.waitFor(() -> {
+ List<ContainerStatus> containerStatuses;
+ try {
+ containerStatuses = containerManager
+ .getContainerStatuses(statRequest).getContainerStatuses();
+ } catch (YarnException | IOException e) {
+ return false;
+ }
+ Assert.assertEquals(1, containerStatuses.size());
+ ContainerStatus status = containerStatuses.get(0);
+ return (status.getState() == expectedState
+ && status.getExecutionType() == ExecutionType.OPPORTUNISTIC);
+ }, 20, 10000);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org