You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/09 15:58:29 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #11693:
[FLINK-17072] Let Dispatcher and ResourceManager use random endpoint id
tillrohrmann commented on a change in pull request #11693: [FLINK-17072] Let Dispatcher and ResourceManager use random endpoint id
URL: https://github.com/apache/flink/pull/11693#discussion_r406308602
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/standalone/StandaloneHaServices.java
##########
@@ -116,7 +108,7 @@ public LeaderRetrievalService getJobManagerLeaderRetriever(JobID jobID) {
synchronized (lock) {
checkNotShutdown();
- return new StandaloneLeaderRetrievalService(jobManagerAddress, DEFAULT_LEADER_ID);
+ return new StandaloneLeaderRetrievalService("UNKNOWN", DEFAULT_LEADER_ID);
Review comment:
No it is not because it is only interested in the leader session id. The address is ignored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services