You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/08/29 11:33:51 UTC

Review Request 71400: Renamed `toAllocate` into `toOffer` in `HierarchialAllocatorProcess`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71400/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Meng Zhu.


Bugs: MESOS-9949
    https://issues.apache.org/jira/browse/MESOS-9949


Repository: mesos


Description
-------

Renamed `toAllocate` into `toOffer` in `HierarchialAllocatorProcess`.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp dd73d5b46c95ac7827d39ed93e0da097f4e8937a 


Diff: https://reviews.apache.org/r/71400/diff/1/


Testing
-------


Thanks,

Andrei Sekretenko

Re: Review Request 71400: Renamed `toAllocate` into `toOffer` in `HierarchialAllocatorProcess`.

Posted by Meng Zhu <mz...@mesosphere.io>.

> On Aug. 29, 2019, 5:32 p.m., Meng Zhu wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Line 2104 (original), 2104 (patched)
> > <https://reviews.apache.org/r/71400/diff/1/?file=2163100#file2163100line2104>
> >
> >     "guaranteesAllocation" and "additionalScalarAllocation" and etc should ideally also be renamed.
> >     
> >     How about:
> >     
> >     `guaranteesAllocation` --> `guaranteesToOffer`
> >     `additionalScalarAllocation` --> `additionalScalars`

Oh, this is addressed in subsequent patches. "ing" also works :)


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71400/#review217500
-----------------------------------------------------------


On Aug. 29, 2019, 4:33 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71400/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2019, 4:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9949
>     https://issues.apache.org/jira/browse/MESOS-9949
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed `toAllocate` into `toOffer` in `HierarchialAllocatorProcess`.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp dd73d5b46c95ac7827d39ed93e0da097f4e8937a 
> 
> 
> Diff: https://reviews.apache.org/r/71400/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 71400: Renamed `toAllocate` into `toOffer` in `HierarchialAllocatorProcess`.

Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71400/#review217500
-----------------------------------------------------------


Fix it, then Ship it!





src/master/allocator/mesos/hierarchical.cpp
Line 2104 (original), 2104 (patched)
<https://reviews.apache.org/r/71400/#comment304759>

    "guaranteesAllocation" and "additionalScalarAllocation" and etc should ideally also be renamed.
    
    How about:
    
    `guaranteesAllocation` --> `guaranteesToOffer`
    `additionalScalarAllocation` --> `additionalScalars`


- Meng Zhu


On Aug. 29, 2019, 4:33 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71400/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2019, 4:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9949
>     https://issues.apache.org/jira/browse/MESOS-9949
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed `toAllocate` into `toOffer` in `HierarchialAllocatorProcess`.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp dd73d5b46c95ac7827d39ed93e0da097f4e8937a 
> 
> 
> Diff: https://reviews.apache.org/r/71400/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 71400: Renamed `toAllocate` into `toOffer` in `HierarchialAllocatorProcess`.

Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71400/
-----------------------------------------------------------

(Updated Sept. 3, 2019, 1:24 p.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Changes
-------

Rebased the patch.


Bugs: MESOS-9949
    https://issues.apache.org/jira/browse/MESOS-9949


Repository: mesos


Description
-------

Renamed `toAllocate` into `toOffer` in `HierarchialAllocatorProcess`.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp dd73d5b46c95ac7827d39ed93e0da097f4e8937a 


Diff: https://reviews.apache.org/r/71400/diff/2/

Changes: https://reviews.apache.org/r/71400/diff/1-2/


Testing
-------


Thanks,

Andrei Sekretenko