You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/14 08:31:28 UTC
[GitHub] [flink] erwan opened a new pull request #14639: [FLINK-20969][API / Scala] Upgrade Scala 2.12 version to 2.12.13
erwan opened a new pull request #14639:
URL: https://github.com/apache/flink/pull/14639
## What is the purpose of the change
Flink is compiled with Scala 2.12.7, that was released in 2018.
The latest version of the 2.12 series is 2.12.13, and upgrading will bring build performance improvements as well as improving compatibility for projects using more recent versions of Scala.
## Brief change log
- Bump Scala 2.12 version to 2.12.13
- Fix tests because of a call that has been removed. Note that the `finish()` method already existed in 2.12.7, and all it did was calling `printSummary()`.
## Verifying this change
This change doesn't introduce any new behavior, so it is covered by the existing test suite of the Scala API.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] erwan commented on pull request #14639: [FLINK-12461][API / Scala] Upgrade Scala 2.12 version to 2.12.13
Posted by GitBox <gi...@apache.org>.
erwan commented on pull request #14639:
URL: https://github.com/apache/flink/pull/14639#issuecomment-843812195
@dhruvrajan I'll close it, see the discussion on JIRA. It seems like this is not going to happen because it breaks binary compatibility (so savepoints would be lost during upgrade).
My understanding is that the current plan is to remove all Scala code from the Flink core, meaning that:
1. The Scala API will only be a wrapper around the core (written in Java) so it can evolve, get support for new version etc without risking to break the core
2. 3rd party Scala API based on the Java core will be possible
3. Using the Java core directly from Scala code will be possible
Meaning that even if the Flink core team doesn't implement support for Scala 3 in the official API (1), it will still be possible with (2) or (3).
You can see details on this ticket: https://issues.apache.org/jira/browse/FLINK-13414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14639: [FLINK-20969][API / Scala] Upgrade Scala 2.12 version to 2.12.13
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14639:
URL: https://github.com/apache/flink/pull/14639#issuecomment-760032294
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b40b5ac2faf8d07403c16dcd975ddee473ef8a1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8b40b5ac2faf8d07403c16dcd975ddee473ef8a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b40b5ac2faf8d07403c16dcd975ddee473ef8a1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14639: [FLINK-20969][API / Scala] Upgrade Scala 2.12 version to 2.12.13
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14639:
URL: https://github.com/apache/flink/pull/14639#issuecomment-760032294
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b40b5ac2faf8d07403c16dcd975ddee473ef8a1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12038",
"triggerID" : "8b40b5ac2faf8d07403c16dcd975ddee473ef8a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b40b5ac2faf8d07403c16dcd975ddee473ef8a1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12038)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] erwan closed pull request #14639: [FLINK-12461][API / Scala] Upgrade Scala 2.12 version to 2.12.13
Posted by GitBox <gi...@apache.org>.
erwan closed pull request #14639:
URL: https://github.com/apache/flink/pull/14639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14639: [FLINK-20969][API / Scala] Upgrade Scala 2.12 version to 2.12.13
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14639:
URL: https://github.com/apache/flink/pull/14639#issuecomment-760019540
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8b40b5ac2faf8d07403c16dcd975ddee473ef8a1 (Thu Jan 14 08:33:13 UTC 2021)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20969).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dhruvrajan commented on pull request #14639: [FLINK-12461][API / Scala] Upgrade Scala 2.12 version to 2.12.13
Posted by GitBox <gi...@apache.org>.
dhruvrajan commented on pull request #14639:
URL: https://github.com/apache/flink/pull/14639#issuecomment-842521051
Hi, any progress on this PR? I wonder if there is room / capacity to support Scala 3 now as well? I would be happy to help with that. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14639: [FLINK-12461][API / Scala] Upgrade Scala 2.12 version to 2.12.13
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14639:
URL: https://github.com/apache/flink/pull/14639#issuecomment-760019540
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8b40b5ac2faf8d07403c16dcd975ddee473ef8a1 (Sat Aug 28 12:10:28 UTC 2021)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dhruvrajan commented on pull request #14639: [FLINK-12461][API / Scala] Upgrade Scala 2.12 version to 2.12.13
Posted by GitBox <gi...@apache.org>.
dhruvrajan commented on pull request #14639:
URL: https://github.com/apache/flink/pull/14639#issuecomment-844348246
Gotcha, that makes sense, thanks @erwan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org