You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "SteveYurongSu (via GitHub)" <gi...@apache.org> on 2024/08/08 02:15:01 UTC
[PR] Pipe: Support converting data type on data sync receiver metadata mismatch [iotdb]
SteveYurongSu opened a new pull request, #13110:
URL: https://github.com/apache/iotdb/pull/13110
As title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pipe: Support converting data type on data sync receiver metadata mismatch [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13110:
URL: https://github.com/apache/iotdb/pull/13110#issuecomment-2274869253
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/13110?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `1.10396%` with `1075 lines` in your changes missing coverage. Please review.
> Project coverage is 41.52%. Comparing base [(`0835630`)](https://app.codecov.io/gh/apache/iotdb/commit/08356308a862cc45301852d4b92143928ad13a0c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`dbe51fb`)](https://app.codecov.io/gh/apache/iotdb/commit/dbe51fb8907fb19d915128772048414f1c5eacf6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 6 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/iotdb/pull/13110?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/receiver/transform/converter/ArrayConverter.java](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Freceiver%2Ftransform%2Fconverter%2FArrayConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9yZWNlaXZlci90cmFuc2Zvcm0vY29udmVydGVyL0FycmF5Q29udmVydGVyLmphdmE=) | 0.00% | [594 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/receiver/transform/converter/ValueConverter.java](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Freceiver%2Ftransform%2Fconverter%2FValueConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9yZWNlaXZlci90cmFuc2Zvcm0vY29udmVydGVyL1ZhbHVlQ29udmVydGVyLmphdmE=) | 0.00% | [335 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../PipeStatementDataTypeConvertExecutionVisitor.java](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Freceiver%2Fvisitor%2FPipeStatementDataTypeConvertExecutionVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9yZWNlaXZlci92aXNpdG9yL1BpcGVTdGF0ZW1lbnREYXRhVHlwZUNvbnZlcnRFeGVjdXRpb25WaXNpdG9yLmphdmE=) | 8.33% | [55 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...orm/statement/PipeConvertedInsertRowStatement.java](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Freceiver%2Ftransform%2Fstatement%2FPipeConvertedInsertRowStatement.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9yZWNlaXZlci90cmFuc2Zvcm0vc3RhdGVtZW50L1BpcGVDb252ZXJ0ZWRJbnNlcnRSb3dTdGF0ZW1lbnQuamF2YQ==) | 0.00% | [37 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../statement/PipeConvertedInsertTabletStatement.java](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Freceiver%2Ftransform%2Fstatement%2FPipeConvertedInsertTabletStatement.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9yZWNlaXZlci90cmFuc2Zvcm0vc3RhdGVtZW50L1BpcGVDb252ZXJ0ZWRJbnNlcnRUYWJsZXRTdGF0ZW1lbnQuamF2YQ==) | 0.00% | [19 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...eceiver/protocol/thrift/IoTDBDataNodeReceiver.java](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Freceiver%2Fprotocol%2Fthrift%2FIoTDBDataNodeReceiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9yZWNlaXZlci9wcm90b2NvbC90aHJpZnQvSW9UREJEYXRhTm9kZVJlY2VpdmVyLmphdmE=) | 7.14% | [13 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ommons/pipe/connector/protocol/IoTDBConnector.java](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fpipe%2Fconnector%2Fprotocol%2FIoTDBConnector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvcGlwZS9jb25uZWN0b3IvcHJvdG9jb2wvSW9UREJDb25uZWN0b3IuamF2YQ==) | 16.66% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...iotdb/commons/pipe/receiver/IoTDBFileReceiver.java](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fpipe%2Freceiver%2FIoTDBFileReceiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvcGlwZS9yZWNlaXZlci9Jb1REQkZpbGVSZWNlaXZlci5qYXZh) | 16.66% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...nector/client/IoTDBDataNodeAsyncClientManager.java](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Fconnector%2Fclient%2FIoTDBDataNodeAsyncClientManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9jb25uZWN0b3IvY2xpZW50L0lvVERCRGF0YU5vZGVBc3luY0NsaWVudE1hbmFnZXIuamF2YQ==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../pipe/connector/client/IoTDBSyncClientManager.java](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fpipe%2Fconnector%2Fclient%2FIoTDBSyncClientManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvcGlwZS9jb25uZWN0b3IvY2xpZW50L0lvVERCU3luY0NsaWVudE1hbmFnZXIuamF2YQ==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [4 more](https://app.codecov.io/gh/apache/iotdb/pull/13110?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #13110 +/- ##
============================================
- Coverage 41.73% 41.52% -0.22%
Complexity 71 71
============================================
Files 3331 3342 +11
Lines 211546 212795 +1249
Branches 25150 25277 +127
============================================
+ Hits 88292 88353 +61
- Misses 123254 124442 +1188
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/13110?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pipe: Support converting data type on data sync receiver metadata mismatch [iotdb]
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #13110:
URL: https://github.com/apache/iotdb/pull/13110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pipe: Support converting data type on data sync receiver metadata mismatch [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13110:
URL: https://github.com/apache/iotdb/pull/13110#issuecomment-2274824806
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13110) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=13110&metric=new_coverage&view=list) (required ≥ 80%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13110)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org