You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/06/29 08:00:10 UTC

[GitHub] [hudi] minihippo commented on a change in pull request #3108: [HUDI-2042] Compare the field object directly in OverwriteWithLatestA…

minihippo commented on a change in pull request #3108:
URL: https://github.com/apache/hudi/pull/3108#discussion_r660374525



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java
##########
@@ -94,6 +94,6 @@ protected boolean isDeleteRecord(GenericRecord genericRecord) {
    * Return true if value equals defaultValue otherwise false.
    */
   public Boolean overwriteField(Object value, Object defaultValue) {
-    return defaultValue == null ? value == null : defaultValue.toString().equals(String.valueOf(value));

Review comment:
       Thanks for reviewing. I add an array type to data schema in the unit test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org