[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #5853: Add Range Indexing support for raw values

[GitBox <gi...@apache.org>]

KKcorps commented on a change in pull request #5853:
URL: https://github.com/apache/incubator-pinot/pull/5853#discussion_r473731043



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/invertedindex/RangeIndexHandler.java
##########
@@ -140,17 +145,64 @@ private void handleDictionaryBasedColumn(ColumnMetadata columnMetadata)
     }
   }
 
+  private void handleNonDictionaryBasedColumn(ColumnMetadata columnMetadata)
+          throws IOException {
+    int numDocs = columnMetadata.getTotalDocs();
+    try (RangeIndexCreator creator = new RangeIndexCreator(_indexDir, columnMetadata.getFieldSpec(),
+            FieldSpec.DataType.INT, -1, -1, numDocs, columnMetadata.getTotalNumberOfEntries())) {
+      try (ForwardIndexReader forwardIndexReader = getForwardIndexReader(columnMetadata, _segmentWriter);
+           ForwardIndexReaderContext readerContext = forwardIndexReader.createContext()) {
+        if (columnMetadata.isSingleValue()) {
+          // Single-value column.
+          for (int i = 0; i < numDocs; i++) {
+            switch (columnMetadata.getDataType()) {

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org