[jira] [Comment Edited] (CASSANDRA-14792) skip TestRepair.test_dead_coordinator dtest in 4.0

["Alex Petrov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-14792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629176#comment-16629176 ] 

Alex Petrov edited comment on CASSANDRA-14792 at 9/26/18 5:34 PM:
------------------------------------------------------------------

+1, thank you for fixing this one! 

For completeness, the test was failing with 

{code}
java.lang.RuntimeException: java.lang.IllegalArgumentException: Invalid state transition FINALIZED -> FAILED
        at org.apache.cassandra.repair.RepairMessageVerbHandler.doVerb(RepairMessageVerbHandler.java:214)
        at org.apache.cassandra.net.MessageDeliveryTask.process(MessageDeliveryTask.java:92)
        at org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:54)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.lang.Thread.run(Thread.java:748)
{code}

This happens only every once in a while, since a completed task is racing with cancel. We could improve a failure message on cancelation if we had a distinction between failed state and cancelled one, but this might be not worth it.


was (Author: ifesdjeen):
+1, thank you for fixing this one! 

> skip TestRepair.test_dead_coordinator dtest in 4.0
> --------------------------------------------------
>
>                 Key: CASSANDRA-14792
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14792
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Minor
>             Fix For: 4.0
>
>
> CASSANDRA-14763 changed the coordinator behavior to not cleanup old repair sessions, so this test doesn't really make sense anymore. We should just skip it in 4.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org