You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/10/08 13:01:57 UTC
[GitHub] spark pull request #22672: [SPARK-25605][TESTS] Alternate take. Run cast str...
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/22672
[SPARK-25605][TESTS] Alternate take. Run cast string to timestamp tests for a subset of timezones
## What changes were proposed in this pull request?
Try testing timezones in parallel instead in CastSuite, instead of random sampling.
See also #22631
## How was this patch tested?
Existing test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-25605.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22672.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22672
----
commit 45658599a8e456684c657166aa896f4e49a40838
Author: Sean Owen <se...@...>
Date: 2018-10-08T13:00:37Z
Try testing timezones in parallel instead in CastSuite
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22672: [SPARK-25605][TESTS] Alternate take. Run cast string to ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22672
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22672: [SPARK-25605][TESTS] Alternate take. Run cast string to ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22672
The original change in #22631 made the test time go down from about 2:30 to 0:17. See build 96945:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96945/testReport/junit/org.apache.spark.sql.catalyst.expressions/CastSuite/cast_string_to_timestamp/history/?start=175
This change clocks in at 0:24 seconds instead of 0:17:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97113/testReport/org.apache.spark.sql.catalyst.expressions/CastSuite/cast_string_to_timestamp/history/
That's still a pretty big win, and keeps all tests. I'd argue this is a step forward. However we could further, I'm sure, trim the number of cases it tests if desired. This could be a case where we do want to be pretty exhaustive though?
And: I suspect there are a lot of other tests we could speed up this way, that loop over some local bit of test code and could easily be run in parallel with a small change like this. It's the Spark-based jobs that are hard to run concurrently.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22672: [SPARK-25605][TESTS] Alternate take. Run cast string to ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22672
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22672: [SPARK-25605][TESTS] Alternate take. Run cast string to ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22672
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3796/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22672: [SPARK-25605][TESTS] Alternate take. Run cast string to ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22672
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97113/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22672: [SPARK-25605][TESTS] Alternate take. Run cast str...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22672
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22672: [SPARK-25605][TESTS] Alternate take. Run cast string to ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22672
**[Test build #97113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97113/testReport)** for PR 22672 at commit [`4565859`](https://github.com/apache/spark/commit/45658599a8e456684c657166aa896f4e49a40838).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22672: [SPARK-25605][TESTS] Alternate take. Run cast string to ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22672
**[Test build #97113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97113/testReport)** for PR 22672 at commit [`4565859`](https://github.com/apache/spark/commit/45658599a8e456684c657166aa896f4e49a40838).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org