[GitHub] [rocketmq] ferrirW commented on a diff in pull request #4213: [ISSUE #4203] Support zstd/lz4 compression to improve send/receive performance

[GitBox <gi...@apache.org>]

ferrirW commented on code in PR #4213:
URL: https://github.com/apache/rocketmq/pull/4213#discussion_r859448995


##########
common/src/main/java/org/apache/rocketmq/common/sysflag/MessageSysFlag.java:
##########
@@ -16,7 +16,21 @@
  */
 package org.apache.rocketmq.common.sysflag;
 
+import org.apache.rocketmq.common.compression.CompressionType;
+
 public class MessageSysFlag {
+
+    /**
+     * Meaning of each bit in the system flag
+     *
+     * | bit    | 7 | 6 | 5         | 4        | 3           | 2                | 1                | 0                |

Review Comment:
   > Start from 0 to 7 would be better to read
   
   I think it would be better to be consistent with the actual physical order



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org