You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/08 07:49:45 UTC
[GitHub] [shardingsphere] xuelijun-dev opened a new pull request, #18240: add sharding-spring-boot-mybatis-example yml config file
xuelijun-dev opened a new pull request, #18240:
URL: https://github.com/apache/shardingsphere/pull/18240
add sharding-spring-boot-mybatis-example yml config file
Changes proposed in this pull request:
- examples/shardingsphere-jdbc-example/single-feature-example/sharding-example/sharding-spring-boot-mybatis-example/src/main/resources/application-sharding-tables.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] soulasuna commented on a diff in pull request #18240: add sharding-spring-boot-mybatis-example yml config file
Posted by GitBox <gi...@apache.org>.
soulasuna commented on code in PR #18240:
URL: https://github.com/apache/shardingsphere/pull/18240#discussion_r930560337
##########
examples/shardingsphere-jdbc-example/single-feature-example/sharding-example/sharding-spring-boot-mybatis-example/src/main/resources/application-sharding-tables.yml:
##########
@@ -0,0 +1,50 @@
+spring:
+ shardingsphere:
Review Comment:
Add license please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed pull request #18240: add sharding-spring-boot-mybatis-example yml config file
Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #18240: add sharding-spring-boot-mybatis-example yml config file
URL: https://github.com/apache/shardingsphere/pull/18240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on pull request #18240: add sharding-spring-boot-mybatis-example yml config file
Posted by GitBox <gi...@apache.org>.
zjcnb commented on PR #18240:
URL: https://github.com/apache/shardingsphere/pull/18240#issuecomment-1150674305
@xuelijun-dev Hi, thank you for your pull request, your pull_request has ci error, and `sharding-spring-boot-mybatis-example` module it only support `xxx.properties`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18240: add sharding-spring-boot-mybatis-example yml config file
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18240:
URL: https://github.com/apache/shardingsphere/pull/18240#issuecomment-1150149318
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18240?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18240](https://codecov.io/gh/apache/shardingsphere/pull/18240?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ad2f659) into [master](https://codecov.io/gh/apache/shardingsphere/commit/72b683cc3d431452b0e645f5bfcfa2f9480e65f2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (72b683c) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #18240 +/- ##
============================================
- Coverage 59.22% 59.22% -0.01%
+ Complexity 2183 2178 -5
============================================
Files 3716 3716
Lines 54571 54550 -21
Branches 9266 9258 -8
============================================
- Hits 32318 32305 -13
+ Misses 19508 19502 -6
+ Partials 2745 2743 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...egistry/status/storage/node/StorageStatusNode.java](https://codecov.io/gh/apache/shardingsphere/pull/18240/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9yZWdpc3RyeS9zdGF0dXMvc3RvcmFnZS9ub2RlL1N0b3JhZ2VTdGF0dXNOb2RlLmphdmE=) | | |
| [...ator/registry/status/storage/node/StorageNode.java](https://codecov.io/gh/apache/shardingsphere/pull/18240/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9yZWdpc3RyeS9zdGF0dXMvc3RvcmFnZS9ub2RlL1N0b3JhZ2VOb2RlLmphdmE=) | `83.33% <0.00%> (ø)` | |
| [...che/shardingsphere/sharding/rule/ShardingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/18240/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcnVsZS9TaGFyZGluZ1J1bGUuamF2YQ==) | `75.69% <0.00%> (+0.83%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18240?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18240?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [72b683c...ad2f659](https://codecov.io/gh/apache/shardingsphere/pull/18240?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #18240: add sharding-spring-boot-mybatis-example yml config file
Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #18240:
URL: https://github.com/apache/shardingsphere/pull/18240#issuecomment-1212707485
I just close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #18240: add sharding-spring-boot-mybatis-example yml config file
Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #18240:
URL: https://github.com/apache/shardingsphere/pull/18240#issuecomment-1207440655
@xuelijun-dev The progress of this PR has not been upgraded for a long time. If there is no update, I will close it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org