You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2016/11/24 05:26:52 UTC

Review Request 54052: RangerResourceMatcher for Hdfs and Yarn resources does not correctly handle policy containing only one resource whose value is "*"

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54052/
-----------------------------------------------------------

Review request for ranger, Madhan Neethiraj and Ramesh Mani.


Bugs: RANGER-1229
    https://issues.apache.org/jira/browse/RANGER-1229


Repository: ranger


Description
-------

HDFS (or YARN) policy containing only "*" as the only path (or queue), and with delegateAdmin set to true is not displayed to a non-admin but valid Ranger user who should be allowed to access/modify it.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java 38260ec 
  agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 7bf30f3 
  agents-common/src/test/resources/resourcematcher/test_resourcematcher_path.json e1730dd 

Diff: https://reviews.apache.org/r/54052/diff/


Testing
-------

Tested with local VM.


Thanks,

Abhay Kulkarni


Re: Review Request 54052: RangerResourceMatcher for Hdfs and Yarn resources does not correctly handle policy containing only one resource whose value is "*"

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54052/#review156814
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On Nov. 24, 2016, 5:26 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54052/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2016, 5:26 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
> 
> 
> Bugs: RANGER-1229
>     https://issues.apache.org/jira/browse/RANGER-1229
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> HDFS (or YARN) policy containing only "*" as the only path (or queue), and with delegateAdmin set to true is not displayed to a non-admin but valid Ranger user who should be allowed to access/modify it.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java 38260ec 
>   agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 7bf30f3 
>   agents-common/src/test/resources/resourcematcher/test_resourcematcher_path.json e1730dd 
> 
> Diff: https://reviews.apache.org/r/54052/diff/
> 
> 
> Testing
> -------
> 
> Tested with local VM.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>