Re: DO NOT REPLY [Bug 45023] DEFLATE preventing 304 NOT MODIFIED response

[Nick Kew <ni...@webthing.com>]

On 19 Aug 2008, at 14:41, bugzilla@apache.org wrote:

> --- Comment #5 from rahul <ra...@sun.com>  2008-08-19 06:41:51 PST ---
> Created an attachment (id=22453)
>  --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22453)
> A POC slightly better than the above conf lines,
>
> Adds an input filter ETAG that can be used like below, along with  
> DEFLATE
> to let apache recognize ($1)-gzip as $1
>
> AddInputFilter ETAG .txt
> AddOutputFilterByType DEFLATE text/plain

Neat little fix (insofar as that problem admits of a neat fix).
But I dislike using an input filter just to manipulate request headers
(that's what processing hooks are for), and the sysop shouldn't
have to configure it.

Does something bad happen if you put the check in a post_read_request
hook instead?

-- 
Nick Kew

Re: DO NOT REPLY [Bug 45023] DEFLATE preventing 304 NOT MODIFIED response

[rahul <ra...@Sun.COM>]

| >Created an attachment (id=22453)
| > --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22453)
| >A POC slightly better than the above conf lines,
| >
| >Adds an input filter ETAG that can be used like below, along with  
| >DEFLATE
| >to let apache recognize ($1)-gzip as $1
| >
| >AddInputFilter ETAG .txt
| >AddOutputFilterByType DEFLATE text/plain
| 
| Neat little fix (insofar as that problem admits of a neat fix).
| But I dislike using an input filter just to manipulate request headers
| (that's what processing hooks are for), and the sysop shouldn't
| have to configure it.
| 
| Does something bad happen if you put the check in a post_read_request
| hook instead?

Thanks for the pointer :). I will update the patch.

                                    rahul
--
1. e4 _