You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by "fzoepffel (via GitHub)" <gi...@apache.org> on 2024/04/22 17:22:30 UTC

[PR] SYSTEMDS-3696/add-custom-JUNIT-tests-for-slicefinder [systemds]

fzoepffel opened a new pull request, #2021:
URL: https://github.com/apache/systemds/pull/2021

   In this PR three basic tests were added to BuiltinSliceFinderTest.java. The three tests test the DML implementation of slicefinder on custom input matrices with 20 (respectively 40) rows and 10 columns and the corresponding error array and a k-value of 10 (alpha = 0.95, minSup = 4). The results of the slicefinder function are compared with the expected result matrix R. 
   
   Contributors:
   zoepffel@campus.tu-berlin.de


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SYSTEMDS-3696/add-custom-JUNIT-tests-for-slicefinder [systemds]

Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.

mboehm7 closed pull request #2021: SYSTEMDS-3696/add-custom-JUNIT-tests-for-slicefinder 
URL: https://github.com/apache/systemds/pull/2021


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SYSTEMDS-3696/add-custom-JUNIT-tests-for-slicefinder [systemds]

Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.

mboehm7 commented on PR #2021:
URL: https://github.com/apache/systemds/pull/2021#issuecomment-2070621662

   LGTM - thanks for the patch @fzoepffel. During the merge, I just made minor adjustments (deleting the slicefinder.txt output file, simplifying the matrix comparison to a single call, and avoiding unnecessarily generating the R inputs).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org