[GitHub] [doris] Gabriel39 commented on a diff in pull request #13426: [fix](year) fix `year()` results are not as expected

[GitBox <gi...@apache.org>]

Gabriel39 commented on code in PR #13426:
URL: https://github.com/apache/doris/pull/13426#discussion_r997667871


##########
be/src/vec/functions/date_time_transforms.h:
##########
@@ -308,7 +308,7 @@ struct Transformer<FromType, ToType, ToYearImpl<FromType>> {
         }
 
         for (size_t i = 0; i < size; ++i) {
-            null_map_ptr[i] = to_ptr[i] <= MIN_YEAR || to_ptr[i] >= MAX_YEAR;

Review Comment:
   This checking rule also should be same as FE. Could you add some cases for FE `year` function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org