You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/09 14:57:24 UTC

[GitHub] [mynewt-core] utzig commented on issue #2233: Fix console echo handling

utzig commented on issue #2233: Fix console echo handling
URL: https://github.com/apache/mynewt-core/pull/2233#issuecomment-596582750
 
 
   ```
            default:
                insert_char(&input->line[cur], byte, end);
   -            /* Falls through. */
   +        /* Falls through. */
            case '\r':
   -            /* Falls through. */
   +        /* Falls through. */
            case '\n':
   ```
   
   Funny one, the style checker does not know what "fall through" means and thinks that your comment applies to the next `case`!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services