[GitHub] [iceberg] jackye1995 commented on pull request #5939: AWS: Fix NotSerializableException when using AssumeRoleAwsClientFactory

[GitBox <gi...@apache.org>]

jackye1995 commented on PR #5939:
URL: https://github.com/apache/iceberg/pull/5939#issuecomment-1272454957

   Thanks for the fix, I also overlooked the fact that the request is not serializable. Technically we can still store the assume role request, just need to not make it as `transient volatile` and initialize it if null. But it feels like an overkill given we probably need the request every 6 hours or so and it's okay to create it at runtime. So I agree this is the right way to fix. Let me know when this is out of draft status and I will review again!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org