You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by kl0u <gi...@git.apache.org> on 2017/10/13 10:03:00 UTC
[GitHub] flink pull request #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer...
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/4821
[FLINK-7835][cep] Fix duplicate() in NFASerializer.
R @aljoscha
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink cep-nfa-serializer-bug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4821.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4821
----
commit fec2521dde5d2a7ba5e5c537788e6dcbc2cbc51e
Author: kkloudas <kk...@gmail.com>
Date: 2017-10-12T13:20:32Z
[FLINK-7835][cep] Fix duplicate() in NFASerializer.
----
---
[GitHub] flink issue #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer.
Posted by shashank734 <gi...@git.apache.org>.
Github user shashank734 commented on the issue:
https://github.com/apache/flink/pull/4821
While applying the patch it's giving a lot of conflicts. I think due to changes in between. So why I had doubts. I'll apply these changes manually.
---
[GitHub] flink issue #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer.
Posted by shashank734 <gi...@git.apache.org>.
Github user shashank734 commented on the issue:
https://github.com/apache/flink/pull/4821
I think I have to wait for 1.4 cause there are a lot of changes in other files too between 1.3.2 release and this commit.
---
[GitHub] flink pull request #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4821#discussion_r144514570
--- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/NonDuplicatingTypeSerializer.java ---
@@ -190,13 +190,6 @@ public int hashCode() {
return typeSerializer.hashCode();
}
- private void readObject(ObjectInputStream ois) throws IOException, ClassNotFoundException {
--- End diff --
removing this means that `elementList` and `identityMap` will not be initialised after deserialisation.
---
[GitHub] flink issue #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer.
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/4821
I think you can but you will have to recompile flink.
---
[GitHub] flink issue #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer.
Posted by shashank734 <gi...@git.apache.org>.
Github user shashank734 commented on the issue:
https://github.com/apache/flink/pull/4821
Can I directly use these changes in the release-1.3.2 tag or there in between dependencies?
---
[GitHub] flink issue #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer.
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/4821
Sorry to hear that @shashank734 . But on the bright side, the RC0 for Flink 1.4 is out:
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/PREVIEW-Release-1-4-0-release-candidate-0-td20237.html
So you can try it and also help us test it.
---
[GitHub] flink issue #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer.
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/4821
Merging this.
---
[GitHub] flink issue #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer.
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/4821
Yes, I think manually is the safest bet.
Either way the 1.4 will come soon and this fix is going to be included.
---
[GitHub] flink pull request #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4821
---
[GitHub] flink issue #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer.
Posted by shashank734 <gi...@git.apache.org>.
Github user shashank734 commented on the issue:
https://github.com/apache/flink/pull/4821
Yeah, But I think 1.4 will take some more couple of weeks. As unable to restore the state, So it's necessary to change for me.
---
[GitHub] flink issue #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer.
Posted by shashank734 <gi...@git.apache.org>.
Github user shashank734 commented on the issue:
https://github.com/apache/flink/pull/4821
Great
---