[jira] [Resolved] (AMQ-4676) ActiveMQ not compliant with JSR-250 (@PostConstruct, @PreDestroy)

["Timothy Bish (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQ-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQ-4676.
-------------------------------

    Resolution: Fixed

Made changes to trunk based on these patches, code has changed a bit since 5.8.0.  Might want to double check that I got them all. 
                
> ActiveMQ not compliant with JSR-250 (@PostConstruct, @PreDestroy)
> -----------------------------------------------------------------
>
>                 Key: AMQ-4676
>                 URL: https://issues.apache.org/jira/browse/AMQ-4676
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: activemq-camel, Broker, stomp
>    Affects Versions: 5.8.0
>            Reporter: Steve Siebert
>             Fix For: 5.9.0
>
>         Attachments: activemq-broker_AMQ-4676v2.diff, activemq-camel_AMQ-4676v2.diff, activemq-spring_AMQ-4676v2.diff, activemq-stomp_AMQ-4676v2.diff
>
>
> ActiveMQ is not compliant with JSR-250, which states:
> 2.5 javax.annotation.PostConstruct:
>  [...]
>  - The method MUST NOT throw a checked exception.
>  - If the method throws an unchecked exception the class MUST NOT be put into
> service. In the case of EJBs the method annotated with PostConstruct can
> handle exceptions and cleanup before the bean instance is discarded.
> 2.6 javax.annotation.PreDestroy
> (same as above)
> An exception was thrown when attempting to deploy an application using the activemq-rar-5.8 on GF 4.0, but I believe it's safe to say that this can occur in different containers - if not now, potentially between container releases.  
> Included are patches that fix this in all ActiveMQ components.  Most check exceptions thrown were Exception, which was changed to RuntimeException (trapped and wrapped).  There were also IOExceptions being thrown, in which case ActiveMQ-broker now has an IORuntimeException class that is thrown.  Any downstream catches that handled the check exceptions have been converted to catch the RuntimeExceptions.
> This was also reported under AMQ-4673, but the scope of that issue was a lot more limited.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira