You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/10 12:01:53 UTC

[GitHub] [shardingsphere] strongduanmu opened a new issue #14672: Add more unit test for SelectStatementContext

strongduanmu opened a new issue #14672:
URL: https://github.com/apache/shardingsphere/issues/14672


   Hi, community:
   
   This issue is to add more unit tests for the SelectStatementContext class. Welcome to claim them.
   
   The specific subtasks are as follows:
   
   - [ ]  Add unit test for SelectStatementContext#isContainsDollarParameterMarker
   - [ ]  Add unit test for SelectStatementContext#isContainsPartialDistinctAggregation
   
   Through this issue, you can understand the process of participating in Apache ShardingSphere, and be familiar with sharding.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on issue #14672: Add more unit test for SelectStatementContext

Posted by GitBox <gi...@apache.org>.
Swastyy commented on issue #14672:
URL: https://github.com/apache/shardingsphere/issues/14672#issuecomment-1024121707


   Hi @strongduanmu , the test cases will be created in a separate file for both of them or inside the SelectStatementContextText.java?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #14672: Add more unit test for SelectStatementContext

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #14672:
URL: https://github.com/apache/shardingsphere/issues/14672#issuecomment-1024257602


   @Swastyy Inside the SelectStatementContextText.java may be better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #14672: Add more unit test for SelectStatementContext

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #14672:
URL: https://github.com/apache/shardingsphere/issues/14672#issuecomment-1009484995


   @Swastyy Welcome, I just assign this issue to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on issue #14672: Add more unit test for SelectStatementContext

Posted by GitBox <gi...@apache.org>.
Swastyy commented on issue #14672:
URL: https://github.com/apache/shardingsphere/issues/14672#issuecomment-1024307435


   > @Swastyy Inside the SelectStatementContextText.java may be better.
   
   Ok, thanks @strongduanmu .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #14672: Add more unit test for SelectStatementContext

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #14672:
URL: https://github.com/apache/shardingsphere/issues/14672#issuecomment-1023943864


   Hi @Swastyy, does this issue has any progress?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on issue #14672: Add more unit test for SelectStatementContext

Posted by GitBox <gi...@apache.org>.
Swastyy commented on issue #14672:
URL: https://github.com/apache/shardingsphere/issues/14672#issuecomment-1009049935


   Hi @strongduanmu Can I please try this once? If I could not I'll inform you. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org