You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 19:51:17 UTC
[GitHub] [arrow-rs] Dandandan opened a new pull request, #1603: Improve performance BooleanbufferBuilder::append_n for `true` values
Dandandan opened a new pull request, #1603:
URL: https://github.com/apache/arrow-rs/pull/1603
# Which issue does this PR close?
Closes #.
# Rationale for this change
`append_n` has a fast path for `false` values, where it skips setting individual bits by using the fact that bits are set to 0 by default in `advance`.
`append_n` is used by some other code, like parquet.
# What changes are included in this PR?
Speed up `append_n` for `true` values.
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed pull request #1603: Improve performance BooleanbufferBuilder::append_n for `true` values
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed pull request #1603: Improve performance BooleanbufferBuilder::append_n for `true` values
URL: https://github.com/apache/arrow-rs/pull/1603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #1603: Improve performance BooleanbufferBuilder::append_n for `true` values
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #1603:
URL: https://github.com/apache/arrow-rs/pull/1603#issuecomment-1402034157
I have "revived" this in https://github.com/apache/arrow-rs/pull/3596 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org