[GitHub] odracci opened a new pull request #3770: [AIRFLOW-XXX] Fix Kubernetes operator with git-sync

[GitBox <gi...@apache.org>]

odracci opened a new pull request #3770: [AIRFLOW-XXX] Fix Kubernetes operator with git-sync
URL: https://github.com/apache/incubator-airflow/pull/3770
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Currently the implementation of git-sync is broken because:
   - git-sync clones the repository in /tmp and not in airflow-dags volume
   - git-sync add a link to point to the revision required but it is not
   taken into account in AIRFLOW__CORE__DAGS_FOLDER
   
   Dags/logs hostPath volume has been added (needed if airflow run in
   kubernetes in local environment)
   
   In this PR I also removed `worker_dags_folder` config because IMO is redundant. In fact is possible to define it in `dags_folder` using a specific `airflow-configmap` for the workers
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   To avoid false positive in CI `load_examples` is set to `False`
   otherwise DAGs from `airflow/example_dags` are always loaded. In this
   way is possible to test `import` in DAGs.
   
   To do so `KubernetesExecutorTest` now uses a specific folder `airflowexample_dags_kubernetes` to run test instead of `airflow/example_dags` and the DAG `example_kubernetes_annotation` imports a an external module
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [ ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services