You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/09/08 13:41:39 UTC
[GitHub] [netbeans] jglick commented on a change in pull request #1404:
[NETBEANS-2925] Possible solution to not to filter out sources from the
buildDir
jglick commented on a change in pull request #1404: [NETBEANS-2925] Possible solution to not to filter out sources from the buildDir
URL: https://github.com/apache/netbeans/pull/1404#discussion_r322010734
##########
File path: groovy/gradle.java/src/org/netbeans/modules/gradle/java/classpath/GradleSourcesImpl.java
##########
@@ -162,13 +164,7 @@ public GradleSourcesImpl(Project proj) {
}
}
}
- Collections.sort(ret, new Comparator<SourceGroup>() {
-
- @Override
- public int compare(SourceGroup o1, SourceGroup o2) {
- return o1.getName().compareTo(o2.getName());
- }
- });
+ Collections.sort(ret, (SourceGroup o1, SourceGroup o2) -> o1.getName().compareTo(o2.getName()));
Review comment:
```suggestion
Collections.sort(ret, Comparator.comparing(SourceGroup::getName));
```
or something like that (look it up).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists