You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org> on 2009/05/26 17:52:45 UTC
[jira] Created: (ZOOKEEPER-416) BookKeeper jar includes unnecessary
files
BookKeeper jar includes unnecessary files
-----------------------------------------
Key: ZOOKEEPER-416
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-416
Project: Zookeeper
Issue Type: Bug
Components: contrib-bookkeeper
Reporter: Flavio Paiva Junqueira
I was checking the bookkeper jar, and I found that it includes some unnecessary files related to junit, such as:
{noformat}
0 Tue May 12 19:00:14 PDT 2009 tmp/
0 Tue May 12 19:00:00 PDT 2009 tmp/test14667.junit.dir/
0 Tue May 12 19:00:08 PDT 2009 tmp/test14667.junit.dir/version-2/
0 Tue May 12 19:00:10 PDT 2009 tmp/test16109.junit.dir/
0 Tue May 12 19:00:16 PDT 2009 tmp/test16109.junit.dir/version-2/
0 Tue May 12 19:00:14 PDT 2009 tmp/test16113.junit.dir/
0 Tue May 12 19:00:16 PDT 2009 tmp/test16113.junit.dir/version-2/
2256 Tue May 12 18:59:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieClientTest.txt
167046 Tue May 12 19:00:00 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieReadWriteTest.txt
13035 Tue May 12 19:00:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.CloseTest.txt
25036 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.LedgerRecoveryTest.txt
896 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.NIOServerFactoryTest.txt
{noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-416) BookKeeper jar includes
unnecessary files
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713452#action_12713452 ]
Flavio Paiva Junqueira commented on ZOOKEEPER-416:
--------------------------------------------------
This is a change to the build.xml file of BookKeeper. It does not require a unit test.
> BookKeeper jar includes unnecessary files
> -----------------------------------------
>
> Key: ZOOKEEPER-416
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-416
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Reporter: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-416.patch
>
>
> I was checking the bookkeper jar, and I found that it includes some unnecessary files related to junit, such as:
> {noformat}
> 0 Tue May 12 19:00:14 PDT 2009 tmp/
> 0 Tue May 12 19:00:00 PDT 2009 tmp/test14667.junit.dir/
> 0 Tue May 12 19:00:08 PDT 2009 tmp/test14667.junit.dir/version-2/
> 0 Tue May 12 19:00:10 PDT 2009 tmp/test16109.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16109.junit.dir/version-2/
> 0 Tue May 12 19:00:14 PDT 2009 tmp/test16113.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16113.junit.dir/version-2/
> 2256 Tue May 12 18:59:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieClientTest.txt
> 167046 Tue May 12 19:00:00 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieReadWriteTest.txt
> 13035 Tue May 12 19:00:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.CloseTest.txt
> 25036 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.LedgerRecoveryTest.txt
> 896 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.NIOServerFactoryTest.txt
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-416) BookKeeper jar includes
unnecessary files
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713964#action_12713964 ]
Hudson commented on ZOOKEEPER-416:
----------------------------------
Integrated in ZooKeeper-trunk #328 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/328/])
. bookkeeper jar includes unnnecessary files. (flavio via mahadev)
> BookKeeper jar includes unnecessary files
> -----------------------------------------
>
> Key: ZOOKEEPER-416
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-416
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-416.patch
>
>
> I was checking the bookkeper jar, and I found that it includes some unnecessary files related to junit, such as:
> {noformat}
> 0 Tue May 12 19:00:14 PDT 2009 tmp/
> 0 Tue May 12 19:00:00 PDT 2009 tmp/test14667.junit.dir/
> 0 Tue May 12 19:00:08 PDT 2009 tmp/test14667.junit.dir/version-2/
> 0 Tue May 12 19:00:10 PDT 2009 tmp/test16109.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16109.junit.dir/version-2/
> 0 Tue May 12 19:00:14 PDT 2009 tmp/test16113.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16113.junit.dir/version-2/
> 2256 Tue May 12 18:59:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieClientTest.txt
> 167046 Tue May 12 19:00:00 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieReadWriteTest.txt
> 13035 Tue May 12 19:00:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.CloseTest.txt
> 25036 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.LedgerRecoveryTest.txt
> 896 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.NIOServerFactoryTest.txt
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-416) BookKeeper jar includes unnecessary
files
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-416:
---------------------------------------------
Fix Version/s: 3.2.0
Status: Patch Available (was: Open)
> BookKeeper jar includes unnecessary files
> -----------------------------------------
>
> Key: ZOOKEEPER-416
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-416
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Reporter: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-416.patch
>
>
> I was checking the bookkeper jar, and I found that it includes some unnecessary files related to junit, such as:
> {noformat}
> 0 Tue May 12 19:00:14 PDT 2009 tmp/
> 0 Tue May 12 19:00:00 PDT 2009 tmp/test14667.junit.dir/
> 0 Tue May 12 19:00:08 PDT 2009 tmp/test14667.junit.dir/version-2/
> 0 Tue May 12 19:00:10 PDT 2009 tmp/test16109.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16109.junit.dir/version-2/
> 0 Tue May 12 19:00:14 PDT 2009 tmp/test16113.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16113.junit.dir/version-2/
> 2256 Tue May 12 18:59:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieClientTest.txt
> 167046 Tue May 12 19:00:00 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieReadWriteTest.txt
> 13035 Tue May 12 19:00:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.CloseTest.txt
> 25036 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.LedgerRecoveryTest.txt
> 896 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.NIOServerFactoryTest.txt
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-416) BookKeeper jar includes
unnecessary files
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713607#action_12713607 ]
Benjamin Reed commented on ZOOKEEPER-416:
-----------------------------------------
+1 looks good. those files shouldn't be there.
> BookKeeper jar includes unnecessary files
> -----------------------------------------
>
> Key: ZOOKEEPER-416
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-416
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Reporter: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-416.patch
>
>
> I was checking the bookkeper jar, and I found that it includes some unnecessary files related to junit, such as:
> {noformat}
> 0 Tue May 12 19:00:14 PDT 2009 tmp/
> 0 Tue May 12 19:00:00 PDT 2009 tmp/test14667.junit.dir/
> 0 Tue May 12 19:00:08 PDT 2009 tmp/test14667.junit.dir/version-2/
> 0 Tue May 12 19:00:10 PDT 2009 tmp/test16109.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16109.junit.dir/version-2/
> 0 Tue May 12 19:00:14 PDT 2009 tmp/test16113.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16113.junit.dir/version-2/
> 2256 Tue May 12 18:59:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieClientTest.txt
> 167046 Tue May 12 19:00:00 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieReadWriteTest.txt
> 13035 Tue May 12 19:00:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.CloseTest.txt
> 25036 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.LedgerRecoveryTest.txt
> 896 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.NIOServerFactoryTest.txt
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-416) BookKeeper jar includes unnecessary
files
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-416:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. thanks flavio.
> BookKeeper jar includes unnecessary files
> -----------------------------------------
>
> Key: ZOOKEEPER-416
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-416
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-416.patch
>
>
> I was checking the bookkeper jar, and I found that it includes some unnecessary files related to junit, such as:
> {noformat}
> 0 Tue May 12 19:00:14 PDT 2009 tmp/
> 0 Tue May 12 19:00:00 PDT 2009 tmp/test14667.junit.dir/
> 0 Tue May 12 19:00:08 PDT 2009 tmp/test14667.junit.dir/version-2/
> 0 Tue May 12 19:00:10 PDT 2009 tmp/test16109.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16109.junit.dir/version-2/
> 0 Tue May 12 19:00:14 PDT 2009 tmp/test16113.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16113.junit.dir/version-2/
> 2256 Tue May 12 18:59:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieClientTest.txt
> 167046 Tue May 12 19:00:00 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieReadWriteTest.txt
> 13035 Tue May 12 19:00:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.CloseTest.txt
> 25036 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.LedgerRecoveryTest.txt
> 896 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.NIOServerFactoryTest.txt
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-416) BookKeeper jar includes
unnecessary files
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar reassigned ZOOKEEPER-416:
---------------------------------------
Assignee: Flavio Paiva Junqueira
> BookKeeper jar includes unnecessary files
> -----------------------------------------
>
> Key: ZOOKEEPER-416
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-416
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-416.patch
>
>
> I was checking the bookkeper jar, and I found that it includes some unnecessary files related to junit, such as:
> {noformat}
> 0 Tue May 12 19:00:14 PDT 2009 tmp/
> 0 Tue May 12 19:00:00 PDT 2009 tmp/test14667.junit.dir/
> 0 Tue May 12 19:00:08 PDT 2009 tmp/test14667.junit.dir/version-2/
> 0 Tue May 12 19:00:10 PDT 2009 tmp/test16109.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16109.junit.dir/version-2/
> 0 Tue May 12 19:00:14 PDT 2009 tmp/test16113.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16113.junit.dir/version-2/
> 2256 Tue May 12 18:59:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieClientTest.txt
> 167046 Tue May 12 19:00:00 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieReadWriteTest.txt
> 13035 Tue May 12 19:00:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.CloseTest.txt
> 25036 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.LedgerRecoveryTest.txt
> 896 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.NIOServerFactoryTest.txt
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-416) BookKeeper jar includes
unnecessary files
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713339#action_12713339 ]
Hadoop QA commented on ZOOKEEPER-416:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12409067/ZOOKEEPER-416.patch
against trunk revision 777662.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/91/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/91/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/91/console
This message is automatically generated.
> BookKeeper jar includes unnecessary files
> -----------------------------------------
>
> Key: ZOOKEEPER-416
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-416
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Reporter: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-416.patch
>
>
> I was checking the bookkeper jar, and I found that it includes some unnecessary files related to junit, such as:
> {noformat}
> 0 Tue May 12 19:00:14 PDT 2009 tmp/
> 0 Tue May 12 19:00:00 PDT 2009 tmp/test14667.junit.dir/
> 0 Tue May 12 19:00:08 PDT 2009 tmp/test14667.junit.dir/version-2/
> 0 Tue May 12 19:00:10 PDT 2009 tmp/test16109.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16109.junit.dir/version-2/
> 0 Tue May 12 19:00:14 PDT 2009 tmp/test16113.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16113.junit.dir/version-2/
> 2256 Tue May 12 18:59:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieClientTest.txt
> 167046 Tue May 12 19:00:00 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieReadWriteTest.txt
> 13035 Tue May 12 19:00:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.CloseTest.txt
> 25036 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.LedgerRecoveryTest.txt
> 896 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.NIOServerFactoryTest.txt
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-416) BookKeeper jar includes unnecessary
files
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-416:
---------------------------------------------
Attachment: ZOOKEEPER-416.patch
This is a one line modification.
> BookKeeper jar includes unnecessary files
> -----------------------------------------
>
> Key: ZOOKEEPER-416
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-416
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Reporter: Flavio Paiva Junqueira
> Attachments: ZOOKEEPER-416.patch
>
>
> I was checking the bookkeper jar, and I found that it includes some unnecessary files related to junit, such as:
> {noformat}
> 0 Tue May 12 19:00:14 PDT 2009 tmp/
> 0 Tue May 12 19:00:00 PDT 2009 tmp/test14667.junit.dir/
> 0 Tue May 12 19:00:08 PDT 2009 tmp/test14667.junit.dir/version-2/
> 0 Tue May 12 19:00:10 PDT 2009 tmp/test16109.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16109.junit.dir/version-2/
> 0 Tue May 12 19:00:14 PDT 2009 tmp/test16113.junit.dir/
> 0 Tue May 12 19:00:16 PDT 2009 tmp/test16113.junit.dir/version-2/
> 2256 Tue May 12 18:59:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieClientTest.txt
> 167046 Tue May 12 19:00:00 PDT 2009 logs/TEST-org.apache.bookkeeper.test.BookieReadWriteTest.txt
> 13035 Tue May 12 19:00:08 PDT 2009 logs/TEST-org.apache.bookkeeper.test.CloseTest.txt
> 25036 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.LedgerRecoveryTest.txt
> 896 Tue May 12 19:00:16 PDT 2009 logs/TEST-org.apache.bookkeeper.test.NIOServerFactoryTest.txt
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.