[GitHub] [ozone] ayushtkn commented on a change in pull request #2752: HDDS-5863. Error message having null fields on volume creation

[GitBox <gi...@apache.org>]

ayushtkn commented on a change in pull request #2752:
URL: https://github.com/apache/ozone/pull/2752#discussion_r732383670



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -2113,16 +2113,19 @@ public boolean checkAcls(OzoneObj obj, RequestContext context,
 
     if (!accessAuthorizer.checkAccess(obj, context)) {
       if (throwIfPermissionDenied) {
+        String volumeName = obj.getVolumeName() != null?
+                obj.getVolumeName() + " ": "";
+        String bucketName = obj.getBucketName() != null?
+                obj.getBucketName() + " ": "";
+        String keyName = obj.getKeyName() != null? obj.getKeyName() : "";

Review comment:
       Just a suggestion
   I think we should prefix Volume:, Bucket: & Key: respectively before the name. Since we are skipping the null entries, At least to denote what the name is.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org