You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2016/11/30 19:25:22 UTC
Review Request 54224: Upgrade History Displays Wrong Upgrade Type
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54224/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-19034
https://issues.apache.org/jira/browse/AMBARI-19034
Repository: ambari
Description
-------
Perform a HOST_ORDERED upgrade. After the upgrade has completed, navigate to the "Upgrade History". The type of upgrade displayed is "Rolling".
Additionally, when clicking on the upgrade, it shows as "HOST_ORDERED" instead of "Host Ordered"
Diffs
-----
ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 3a78e30
ambari-web/app/mappers/stack_upgrade_history_mapper.js 63088a7
ambari-web/app/messages.js a16d0ea
ambari-web/app/models/stack_version/stack_upgrade_history.js d4a89dc
ambari-web/app/styles/stack_versions.less f67e03e
ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_details_view.js 983c26a
ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 31e1478
Diff: https://reviews.apache.org/r/54224/diff/
Testing
-------
20020 tests complete (27 seconds)
155 tests pending
Thanks,
Andrii Tkach
Re: Review Request 54224: Upgrade History Displays Wrong Upgrade Type
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54224/#review157568
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On \u0414\u0435\u043a. 1, 2016, 10:13 \u0434.\u043f., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54224/
> -----------------------------------------------------------
>
> (Updated \u0414\u0435\u043a. 1, 2016, 10:13 \u0434.\u043f.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-19034
> https://issues.apache.org/jira/browse/AMBARI-19034
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Perform a HOST_ORDERED upgrade. After the upgrade has completed, navigate to the "Upgrade History". The type of upgrade displayed is "Rolling".
> Additionally, when clicking on the upgrade, it shows as "HOST_ORDERED" instead of "Host Ordered"
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 3a78e30
> ambari-web/app/mappers/stack_upgrade_history_mapper.js 63088a7
> ambari-web/app/messages.js a16d0ea
> ambari-web/app/models/stack_version/stack_upgrade_history.js d4a89dc
> ambari-web/app/styles/stack_versions.less f67e03e
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_details_view.js 983c26a
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 31e1478
>
> Diff: https://reviews.apache.org/r/54224/diff/
>
>
> Testing
> -------
>
> 20020 tests complete (27 seconds)
> 155 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 54224: Upgrade History Displays Wrong Upgrade Type
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54224/#review157599
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On Dec. 1, 2016, 10:13 a.m., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54224/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2016, 10:13 a.m.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-19034
> https://issues.apache.org/jira/browse/AMBARI-19034
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Perform a HOST_ORDERED upgrade. After the upgrade has completed, navigate to the "Upgrade History". The type of upgrade displayed is "Rolling".
> Additionally, when clicking on the upgrade, it shows as "HOST_ORDERED" instead of "Host Ordered"
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 3a78e30
> ambari-web/app/mappers/stack_upgrade_history_mapper.js 63088a7
> ambari-web/app/messages.js a16d0ea
> ambari-web/app/models/stack_version/stack_upgrade_history.js d4a89dc
> ambari-web/app/styles/stack_versions.less f67e03e
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_details_view.js 983c26a
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 31e1478
>
> Diff: https://reviews.apache.org/r/54224/diff/
>
>
> Testing
> -------
>
> 20020 tests complete (27 seconds)
> 155 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 54224: Upgrade History Displays Wrong Upgrade Type
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54224/
-----------------------------------------------------------
(Updated Dec. 1, 2016, 10:13 a.m.)
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-19034
https://issues.apache.org/jira/browse/AMBARI-19034
Repository: ambari
Description
-------
Perform a HOST_ORDERED upgrade. After the upgrade has completed, navigate to the "Upgrade History". The type of upgrade displayed is "Rolling".
Additionally, when clicking on the upgrade, it shows as "HOST_ORDERED" instead of "Host Ordered"
Diffs (updated)
-----
ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 3a78e30
ambari-web/app/mappers/stack_upgrade_history_mapper.js 63088a7
ambari-web/app/messages.js a16d0ea
ambari-web/app/models/stack_version/stack_upgrade_history.js d4a89dc
ambari-web/app/styles/stack_versions.less f67e03e
ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_details_view.js 983c26a
ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 31e1478
Diff: https://reviews.apache.org/r/54224/diff/
Testing
-------
20020 tests complete (27 seconds)
155 tests pending
Thanks,
Andrii Tkach
Re: Review Request 54224: Upgrade History Displays Wrong Upgrade Type
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54224/#review157444
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Nov. 30, 2016, 7:25 p.m., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54224/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 7:25 p.m.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-19034
> https://issues.apache.org/jira/browse/AMBARI-19034
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Perform a HOST_ORDERED upgrade. After the upgrade has completed, navigate to the "Upgrade History". The type of upgrade displayed is "Rolling".
> Additionally, when clicking on the upgrade, it shows as "HOST_ORDERED" instead of "Host Ordered"
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 3a78e30
> ambari-web/app/mappers/stack_upgrade_history_mapper.js 63088a7
> ambari-web/app/messages.js a16d0ea
> ambari-web/app/models/stack_version/stack_upgrade_history.js d4a89dc
> ambari-web/app/styles/stack_versions.less f67e03e
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_details_view.js 983c26a
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 31e1478
>
> Diff: https://reviews.apache.org/r/54224/diff/
>
>
> Testing
> -------
>
> 20020 tests complete (27 seconds)
> 155 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 54224: Upgrade History Displays Wrong Upgrade Type
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54224/#review157449
-----------------------------------------------------------
ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js (line 294)
<https://reviews.apache.org/r/54224/#comment228048>
var displayName = type ? type.get('displayName') : record.get('upgradeType');
Should still try to normalize the name, so that "FUTURE_UPGRADE_TYPE" can be converted to "Future Upgrade Type"
- Di Li
On Nov. 30, 2016, 7:25 p.m., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54224/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 7:25 p.m.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-19034
> https://issues.apache.org/jira/browse/AMBARI-19034
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Perform a HOST_ORDERED upgrade. After the upgrade has completed, navigate to the "Upgrade History". The type of upgrade displayed is "Rolling".
> Additionally, when clicking on the upgrade, it shows as "HOST_ORDERED" instead of "Host Ordered"
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 3a78e30
> ambari-web/app/mappers/stack_upgrade_history_mapper.js 63088a7
> ambari-web/app/messages.js a16d0ea
> ambari-web/app/models/stack_version/stack_upgrade_history.js d4a89dc
> ambari-web/app/styles/stack_versions.less f67e03e
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_details_view.js 983c26a
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 31e1478
>
> Diff: https://reviews.apache.org/r/54224/diff/
>
>
> Testing
> -------
>
> 20020 tests complete (27 seconds)
> 155 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>