You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/15 21:38:00 UTC
[jira] [Commented] (BEAM-3218) Change PubsubBoundedWriter to check
total byte size
[ https://issues.apache.org/jira/browse/BEAM-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293284#comment-16293284 ]
ASF GitHub Bot commented on BEAM-3218:
--------------------------------------
nguyent opened a new pull request #4275: [BEAM-3218] Added Quota checks for PubsubMessage in PubsubBoundedWriter
URL: https://github.com/apache/beam/pull/4275
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
[BEAM-3218](https://issues.apache.org/jira/browse/BEAM-3218)
This PR adds a check in the PubsubBoundedWriter to ensure the size of a publish request is within the allowed quota. There's an additional change in the PR which also adds quota checks on PubsubMessage object creation, specifically ensuring a message does not:
* have more than 100 attributes
* attr key > 256 bytes
* attr val > 1024 bytes
* single message size > 10mb
based on the quotas [here](https://cloud.google.com/pubsub/quotas#other_limits).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Change PubsubBoundedWriter to check total byte size
> ---------------------------------------------------
>
> Key: BEAM-3218
> URL: https://issues.apache.org/jira/browse/BEAM-3218
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-gcp
> Reporter: Thang Nguyen
> Assignee: Reuven Lax
> Priority: Minor
>
> The PubsubBoundedWriter [does not check|https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java#L895-L897] the total byte size of outgoing messages when publishing.
> AC:
> * Add a check to ensure the total bytes of the outgoing messages is less than pubsub's allowed max
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)