You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2023/03/29 02:17:13 UTC
[GitHub] [incubator-uniffle] zuston opened a new pull request, #776: chore(spark): remove noisy log in client side
zuston opened a new pull request, #776:
URL: https://github.com/apache/incubator-uniffle/pull/776
### What changes were proposed in this pull request?
1. Remove unnecessary log
2. Make some unimportant log with debug level.
3. Remove extra spaces
### Why are the changes needed?
Avoid too much noisy log in client side when running spark jobs
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Don't need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #776: [MINOR] chore(spark): remove noisy log in client side
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #776:
URL: https://github.com/apache/incubator-uniffle/pull/776#issuecomment-1487858745
## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/776?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#776](https://codecov.io/gh/apache/incubator-uniffle/pull/776?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c3abca) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/1b48c12026ad7be42368fb6eee2cd9a1dff2bbb5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b48c12) will **increase** coverage by `2.49%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #776 +/- ##
============================================
+ Coverage 61.16% 63.65% +2.49%
- Complexity 1985 2001 +16
============================================
Files 245 231 -14
Lines 13422 11455 -1967
Branches 1125 1125
============================================
- Hits 8209 7292 -917
+ Misses 4751 3761 -990
+ Partials 462 402 -60
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/uniffle/client/impl/ShuffleWriteClientImpl.java](https://codecov.io/gh/apache/incubator-uniffle/pull/776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9pbXBsL1NodWZmbGVXcml0ZUNsaWVudEltcGwuamF2YQ==) | `33.41% <ø> (+0.08%)` | :arrow_up: |
| [...pache/spark/shuffle/writer/WriteBufferManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvV3JpdGVCdWZmZXJNYW5hZ2VyLmphdmE=) | `85.78% <100.00%> (ø)` | |
| [...ge/handler/impl/PooledHdfsShuffleWriteHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9Qb29sZWRIZGZzU2h1ZmZsZVdyaXRlSGFuZGxlci5qYXZh) | `43.47% <100.00%> (ø)` | |
... and [17 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston merged pull request #776: [MINOR] chore(spark): remove noisy log in client side
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #776:
URL: https://github.com/apache/incubator-uniffle/pull/776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org