You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/07 07:23:51 UTC
[GitHub] [kafka] skaundinya15 commented on a change in pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped
skaundinya15 commented on a change in pull request #10973:
URL: https://github.com/apache/kafka/pull/10973#discussion_r665108901
##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##########
@@ -141,9 +147,16 @@ private void handleError(
failed.put(groupId, error.exception());
break;
case COORDINATOR_LOAD_IN_PROGRESS:
+ // If the coordinator is in the middle of loading, then we just need to retry
+ log.debug("OffsetCommit request for group {} failed because the coordinator" +
Review comment:
Could we use the `apiName` function for the request in the logs? Would be good to change it here and in all the other handler classes.
##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##########
@@ -141,9 +147,16 @@ private void handleError(
failed.put(groupId, error.exception());
break;
case COORDINATOR_LOAD_IN_PROGRESS:
+ // If the coordinator is in the middle of loading, then we just need to retry
+ log.debug("OffsetCommit request for group {} failed because the coordinator" +
+ " is still in the process of loading state. Will retry. Will retry", groupId);
+ break;
case COORDINATOR_NOT_AVAILABLE:
Review comment:
As I understand it, we also retry if we get a `COORDINATOR_NOT_AVAILABLE` exception. Can we add a `DEBUG` level log statement stating this and that we will retry? Will be good to mimic what we do for the other retriable errors for `COORDINATOR_NOT_AVAILABLE` errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org