You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/05/27 04:14:39 UTC
[GitHub] [hadoop-ozone] maobaolong opened a new pull request #972: HDDS-3665. Container info command should print uuid of datanode
maobaolong opened a new pull request #972:
URL: https://github.com/apache/hadoop-ozone/pull/972
## What changes were proposed in this pull request?
Display the uuid of the datanode to distinguish the datanodes in a same nodes.
With this PR, we can get the following result when info container, in fact i have 5 datanode in the same machine.
```bash
Container id: 1
Pipeline id: f47e37ff-7f7e-453b-9bcc-a58e8117b66f
Container State: CLOSED
Datanodes: [localhost, localhost, localhost]
```
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3665
## How was this patch tested?
```bash
bin/ozone admin container info 1
Container id: 1
Pipeline id: f47e37ff-7f7e-453b-9bcc-a58e8117b66f
Container State: CLOSED
Datanodes: [c4dcebcf-3997-4ebd-a501-8d7c3053de61/localhost,
5d7d5f77-57c6-4c90-8edf-eb0f872a0166/localhost,
aa01cb2c-6742-4938-a719-1dc75f76e88f/localhost]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #972: HDDS-3665. Container info command should print uuid of datanode
Posted by GitBox <gi...@apache.org>.
dineshchitlangia commented on a change in pull request #972:
URL: https://github.com/apache/hadoop-ozone/pull/972#discussion_r430840967
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java
##########
@@ -66,9 +66,14 @@ public Void call() throws Exception {
// Print pipeline of an existing container.
String machinesStr = container.getPipeline().getNodes().stream().map(
- DatanodeDetails::getHostName).collect(Collectors.joining(","));
+ InfoSubcommand::buildDatanodeDisplay)
+ .collect(Collectors.joining(",\n"));
LOG.info("Datanodes: [{}]", machinesStr);
return null;
}
}
+
+ private static String buildDatanodeDisplay(DatanodeDetails details) {
Review comment:
Trivial NIT:
```suggestion
private static String buildDatanodeDetails(DatanodeDetails details) {
```
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java
##########
@@ -66,9 +66,14 @@ public Void call() throws Exception {
// Print pipeline of an existing container.
String machinesStr = container.getPipeline().getNodes().stream().map(
- DatanodeDetails::getHostName).collect(Collectors.joining(","));
+ InfoSubcommand::buildDatanodeDisplay)
Review comment:
```suggestion
InfoSubcommand::buildDatanodeDetails)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #972: HDDS-3665. Container info command should print uuid of datanode
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #972:
URL: https://github.com/apache/hadoop-ozone/pull/972#issuecomment-634411390
@dineshchitlangia Thank you for telling me this skill, i got it and it is useful for me, Thank you for your quick review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #972: HDDS-3665. Container info command should print uuid of datanode
Posted by GitBox <gi...@apache.org>.
dineshchitlangia merged pull request #972:
URL: https://github.com/apache/hadoop-ozone/pull/972
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org