You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "TaoZex (via GitHub)" <gi...@apache.org> on 2023/06/02 15:30:59 UTC

[GitHub] [seatunnel] TaoZex commented on a diff in pull request #4867: [Hotfix][Zeta] Fix deploy operation timeout but task already finished bug

TaoZex commented on code in PR #4867:
URL: https://github.com/apache/seatunnel/pull/4867#discussion_r1214528392


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinatorStatus.java:
##########
@@ -18,9 +18,18 @@
 package org.apache.seatunnel.engine.server.checkpoint;
 
 public enum CheckpointCoordinatorStatus {
+    RUNNING,
+
     FINISHED,
 
     CANCELED,
 
-    FAILED;
+    FAILED,
+
+    /** for savepoint job */
+    SUSPEND;
+
+    public boolean isEndState() {
+        return this == FINISHED || this == CANCELED || this == FAILED || this == SUSPEND;

Review Comment:
   ```suggestion
           return this != RUNNING;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org