[GitHub] [beam] lukecwik commented on a diff in pull request #25338: Change to a separate UnboundedScheduledExecutor for finalizations.

["lukecwik (via GitHub)" <gi...@apache.org>]

lukecwik commented on code in PR #25338:
URL: https://github.com/apache/beam/pull/25338#discussion_r1097676392


##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java:
##########
@@ -219,6 +219,10 @@ public static void main(
     ShortIdMap metricsShortIds = new ShortIdMap();
     ExecutorService executorService =
         options.as(ExecutorOptions.class).getScheduledExecutorService();
+    // In order to reduce memory spent on per-thread coders and buffers, we separate finalizations
+    // from standard bundle processing.
+    ExecutorService finalizationExecutorService =

Review Comment:
   This will be the same instance as the line above on 221



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org