[commons-vfs] 11/18: Added JarArchiveComparatorOptions, Update of README.md

[gg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to annotated tag japicmp-base-0.0.1
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git

commit ef67f5fbe22531c9e161debe143c4292dde567b8
Author: siom79 <ma...@googlemail.com>
AuthorDate: Thu Oct 3 12:07:55 2013 +0200

    Added JarArchiveComparatorOptions, Update of README.md
---
 README.md                                               |  2 +-
 .../src/test/java/japicmp/test/BasicTest.java           |  3 ++-
 japicmp/src/main/java/japicmp/JApiCmp.java              |  3 ++-
 .../src/main/java/japicmp/cmp/JarArchiveComparator.java |  4 ++++
 .../java/japicmp/cmp/JarArchiveComparatorOptions.java   | 17 +++++++++++++++++
 5 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index a6502ab..2b21e44 100644
--- a/README.md
+++ b/README.md
@@ -12,7 +12,7 @@ It can also be used as a library to integrate its functionality in some other ki
 
 ##Motivation##
 
-Every time you make a new release of a library or a product you have to tell your clients or customers what
+Every time you make a new release of a library or a product, you have to tell your clients or customers what
 has changed in comparison to the last release. Without the appropriate tooling, this task is tedious and error-prone.
 This tool/library helps you to determine the differences between the java class files that are contained in the two
 jar archives.
diff --git a/japicmp-testbase/japicmp-test/src/test/java/japicmp/test/BasicTest.java b/japicmp-testbase/japicmp-test/src/test/java/japicmp/test/BasicTest.java
index e650051..7abab9b 100644
--- a/japicmp-testbase/japicmp-test/src/test/java/japicmp/test/BasicTest.java
+++ b/japicmp-testbase/japicmp-test/src/test/java/japicmp/test/BasicTest.java
@@ -1,6 +1,7 @@
 package japicmp.test;
 
 import japicmp.cmp.JarArchiveComparator;
+import japicmp.cmp.JarArchiveComparatorOptions;
 import japicmp.model.JApiChangeStatus;
 import japicmp.model.JApiClass;
 import japicmp.model.JApiMethod;
@@ -17,7 +18,7 @@ public class BasicTest {
 
     @Test
     public void test() {
-        JarArchiveComparator jarArchiveComparator = new JarArchiveComparator();
+        JarArchiveComparator jarArchiveComparator = new JarArchiveComparator(new JarArchiveComparatorOptions());
         List<JApiClass> jApiClasses = jarArchiveComparator.compare(getArchive("japicmp-test-v1.jar"), getArchive("japicmp-test-v2.jar"));
         assertThat(jApiClasses.size(), is(3));
         JApiClass jApiClassRemoved = getJApiClass(jApiClasses, Removed.class.getName());
diff --git a/japicmp/src/main/java/japicmp/JApiCmp.java b/japicmp/src/main/java/japicmp/JApiCmp.java
index 51496ab..6d55a17 100644
--- a/japicmp/src/main/java/japicmp/JApiCmp.java
+++ b/japicmp/src/main/java/japicmp/JApiCmp.java
@@ -2,6 +2,7 @@ package japicmp;
 
 import japicmp.cli.CliParser;
 import japicmp.cmp.JarArchiveComparator;
+import japicmp.cmp.JarArchiveComparatorOptions;
 import japicmp.config.Options;
 import japicmp.model.JApiClass;
 import japicmp.output.OutputTransformer;
@@ -18,7 +19,7 @@ public class JApiCmp {
         File oldArchive = new File(options.getOldArchive());
         File newArchive = new File(options.getNewArchive());
         verifyFilesExist(oldArchive, newArchive);
-        JarArchiveComparator jarArchiveComparator = new JarArchiveComparator();
+        JarArchiveComparator jarArchiveComparator = new JarArchiveComparator(new JarArchiveComparatorOptions());
         List<JApiClass> jApiClasses = jarArchiveComparator.compare(oldArchive, newArchive);
         generateOutput(options, oldArchive, newArchive, jApiClasses);
     }
diff --git a/japicmp/src/main/java/japicmp/cmp/JarArchiveComparator.java b/japicmp/src/main/java/japicmp/cmp/JarArchiveComparator.java
index 0f150c2..06097d1 100644
--- a/japicmp/src/main/java/japicmp/cmp/JarArchiveComparator.java
+++ b/japicmp/src/main/java/japicmp/cmp/JarArchiveComparator.java
@@ -15,6 +15,10 @@ import java.util.jar.JarFile;
 public class JarArchiveComparator {
     private static final Logger logger = Logger.getLogger(JarArchiveComparator.class);
 
+    public JarArchiveComparator(JarArchiveComparatorOptions options) {
+
+    }
+
     public List<JApiClass> compare(File oldArchive, File newArchive) {
         ClassPool classPool = new ClassPool();
         try {
diff --git a/japicmp/src/main/java/japicmp/cmp/JarArchiveComparatorOptions.java b/japicmp/src/main/java/japicmp/cmp/JarArchiveComparatorOptions.java
new file mode 100644
index 0000000..c474ef6
--- /dev/null
+++ b/japicmp/src/main/java/japicmp/cmp/JarArchiveComparatorOptions.java
@@ -0,0 +1,17 @@
+package japicmp.cmp;
+
+import java.util.LinkedList;
+import java.util.List;
+
+public class JarArchiveComparatorOptions {
+    private List<String> packagesInclude = new LinkedList<String>();
+    private List<String> packagesExclude = new LinkedList<String>();
+
+    public List<String> getPackagesExclude() {
+        return packagesExclude;
+    }
+
+    public List<String> getPackagesInclude() {
+        return packagesInclude;
+    }
+}