You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Dannysw <gi...@git.apache.org> on 2016/01/27 02:14:00 UTC

[GitHub] cordova-android pull request: Clearing appPlugin when loading page...

GitHub user Dannysw opened a pull request:

    https://github.com/apache/cordova-android/pull/253

    Clearing appPlugin when loading pages.

    When changing a page the appPlugin becomes stale, causing the "backbutton" and other events to no longer be passable from the CordovaWebView. By setting it to null when a page is loaded it will force the updated appPlugin when it is needed next.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Dannysw/cordova-android master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #253
    
----
commit 55eb646d7f70ffb8ea8b51b6f74fbee8367b0aa5
Author: Daniel Scott-Weekly <ds...@gmail.com>
Date:   2016-01-27T01:07:55Z

    When changing a page the appPlugin becomes stale, causing the "backbutton" and other events to no longer be passable from the CordovaWebView. By setting it to null when a page is loaded it will force the updated appPlugin when it is needed next.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-android pull request: Clearing appPlugin when loading page...

Posted by Dannysw <gi...@git.apache.org>.
Github user Dannysw commented on the pull request:

    https://github.com/apache/cordova-android/pull/253#issuecomment-184034061
  
    Jira ticket https://issues.apache.org/jira/browse/CB-10614


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-android pull request #253: Clearing appPlugin when loading pages.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-android/pull/253


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org